Add command column to pg_stat_progress_create_index

Started by Peter Eisentrautalmost 7 years ago7 messageshackers
Jump to latest
#1Peter Eisentraut
peter_e@gmx.net

I propose to add a column "command" to pg_stat_progress_create_index.
The sibling view pg_stat_progress_cluster already contains such a
column. This can help distinguish which command is running and thus
which phases to expect. It seems reasonable to keep these views
consistent, too. (They are both new in PG12.) Patch attached.

--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

Attachments:

0001-Add-command-column-to-pg_stat_progress_create_index.patchtext/plain; charset=UTF-8; name=0001-Add-command-column-to-pg_stat_progress_create_index.patch; x-mac-creator=0; x-mac-type=0Download+39-2
#2Andres Freund
andres@anarazel.de
In reply to: Peter Eisentraut (#1)
Re: Add command column to pg_stat_progress_create_index

Hi,

On 2019-05-27 14:18:12 -0400, Peter Eisentraut wrote:

I propose to add a column "command" to pg_stat_progress_create_index.
The sibling view pg_stat_progress_cluster already contains such a
column. This can help distinguish which command is running and thus
which phases to expect. It seems reasonable to keep these views
consistent, too. (They are both new in PG12.) Patch attached.

Seems like we should do that for v12 then?

Greetings,

Andres Freund

#3Alvaro Herrera
alvherre@2ndquadrant.com
In reply to: Peter Eisentraut (#1)
Re: Add command column to pg_stat_progress_create_index

On 2019-May-27, Peter Eisentraut wrote:

I propose to add a column "command" to pg_stat_progress_create_index.
The sibling view pg_stat_progress_cluster already contains such a
column. This can help distinguish which command is running and thus
which phases to expect. It seems reasonable to keep these views
consistent, too. (They are both new in PG12.) Patch attached.

+1.

--
�lvaro Herrera https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

#4Fabrízio de Royes Mello
fabriziomello@gmail.com
In reply to: Alvaro Herrera (#3)
Re: Add command column to pg_stat_progress_create_index

On Mon, May 27, 2019 at 4:51 PM Alvaro Herrera <alvherre@2ndquadrant.com>
wrote:

On 2019-May-27, Peter Eisentraut wrote:

I propose to add a column "command" to pg_stat_progress_create_index.
The sibling view pg_stat_progress_cluster already contains such a
column. This can help distinguish which command is running and thus
which phases to expect. It seems reasonable to keep these views
consistent, too. (They are both new in PG12.) Patch attached.

+1.

+1

--
Fabrízio de Royes Mello Timbira - http://www.timbira.com.br/
PostgreSQL: Consultoria, Desenvolvimento, Suporte 24x7 e Treinamento

#5Michael Paquier
michael@paquier.xyz
In reply to: Andres Freund (#2)
Re: Add command column to pg_stat_progress_create_index

On Mon, May 27, 2019 at 11:20:28AM -0700, Andres Freund wrote:

On 2019-05-27 14:18:12 -0400, Peter Eisentraut wrote:

I propose to add a column "command" to pg_stat_progress_create_index.
The sibling view pg_stat_progress_cluster already contains such a
column. This can help distinguish which command is running and thus
which phases to expect. It seems reasonable to keep these views
consistent, too. (They are both new in PG12.) Patch attached.

Seems like we should do that for v12 then?

+1.
--
Michael
#6David Fetter
david@fetter.org
In reply to: Andres Freund (#2)
Re: Add command column to pg_stat_progress_create_index

On Mon, May 27, 2019 at 11:20:28AM -0700, Andres Freund wrote:

Hi,

On 2019-05-27 14:18:12 -0400, Peter Eisentraut wrote:

I propose to add a column "command" to pg_stat_progress_create_index.
The sibling view pg_stat_progress_cluster already contains such a
column. This can help distinguish which command is running and thus
which phases to expect. It seems reasonable to keep these views
consistent, too. (They are both new in PG12.) Patch attached.

Seems like we should do that for v12 then?

+1

Best,
David.
--
David Fetter <david(at)fetter(dot)org> http://fetter.org/
Phone: +1 415 235 3778

Remember to vote!
Consider donating to Postgres: http://www.postgresql.org/about/donate

#7Peter Eisentraut
peter_e@gmx.net
In reply to: Peter Eisentraut (#1)
Re: Add command column to pg_stat_progress_create_index

On 2019-05-27 20:18, Peter Eisentraut wrote:

I propose to add a column "command" to pg_stat_progress_create_index.
The sibling view pg_stat_progress_cluster already contains such a
column. This can help distinguish which command is running and thus
which phases to expect. It seems reasonable to keep these views
consistent, too. (They are both new in PG12.) Patch attached.

committed

--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services