Sep 2019

7 commits
Implement parse_datetime() function
25 Sep 2019Alexander Korotkovmaster13beta1REL_19_STABLE13beta1REL_18_STABLE13beta1REL_17_STABLE13beta1REL_16_STABLE13beta1REL_15_STABLE13beta1REL_14_STABLE13beta1REL_13_STABLE13beta1Also in: jsonpath (not this thread)
LLM analysis, 99% suremodified before commitlight changesfrom patchset #200 of 2 reviewers saw the final version

Matches the parse_datetime() component of #20, except that DCH_datetime_type() omits two dangling RR/RRRR cases belonging to the deferred year-pattern patch. This matching September submission is newer than the supplied sources in thread #37997.

  • Anastasia Lubennikovasaw an earlier versiontrailerTested conversion and identified the obsolete tzname contract in #4, before the strict-parsing implementation was reworked into standard mode.
  • Peter Eisentrautsaw an earlier versiontrailerRequested separating parse_datetime() and its API changes from format-pattern support in #8, before the resulting split and parsing-mode changes.
Error suppression support for upcoming jsonpath .datetime() method
25 Sep 2019Alexander Korotkovmaster13beta1REL_19_STABLE13beta1REL_18_STABLE13beta1REL_17_STABLE13beta1REL_16_STABLE13beta1REL_15_STABLE13beta1REL_14_STABLE13beta1REL_13_STABLE13beta1
LLM analysis, 97% surelanded as postedfrom patchset #200 of 2 reviewers saw the final version

Matches the error-suppression component of #20 apart from rebasing away two deletions of RR/RRRR labels that were absent from the committed prerequisite.

  • Anastasia Lubennikovasaw an earlier versiontrailerExamined RETURN_ERROR and its implicit have_error argument in #4, before error suppression was extended to the new standard-mode separator checks.
  • Peter Eisentrautno review foundtrailerThe visible review in #8 addresses conversion templates and API organization rather than the error-suppression component.
Allow datetime values in JsonbValue
25 Sep 2019Alexander Korotkovmaster13beta1REL_19_STABLE13beta1REL_18_STABLE13beta1REL_17_STABLE13beta1REL_16_STABLE13beta1REL_15_STABLE13beta1REL_14_STABLE13beta1REL_13_STABLE13beta1Also in: jsonpath (not this thread)
LLM analysis, 100% surelanded as postedfrom patchset #201 of 2 reviewers saw the final version

The JsonbValue component of #20 has identical added and removed lines, including datetime storage and timezone-preserving serialization. Its September submission supersedes the earlier material listed for thread #37997.

  • Anastasia Lubennikovasaw the final versiontrailerIdentified the jbvDatetime diagnostic and redundant JENTRY_ISSTRING flag in #4, after which this component received only light fixes and comment edits.
  • Peter Eisentrautno review foundtrailerHis visible review in #8 concerns datetime conversion and format templates, with no review of the JsonbValue representation component.
Implement jsonpath .datetime() method
25 Sep 2019Alexander Korotkovmaster13beta1REL_19_STABLE13beta1REL_18_STABLE13beta1REL_17_STABLE13beta1REL_16_STABLE13beta1REL_15_STABLE13beta1REL_14_STABLE13beta1REL_13_STABLE13beta1Also in: jsonpath (not this thread)
LLM analysis, 100% suremodified before commitmoderate changesfrom patchset #200 of 2 reviewers saw the final version

Matches the .datetime() component of #20, with committer changes making system_views.sql wrappers STABLE, assigning catalog OIDs, bumping catversion, and revising documentation and diagnostics. This September source is later than every supplied patchset in thread #37997.

  • Anastasia Lubennikovasaw an earlier versiontrailerTested the feature and challenged format ordering, documentation, and diagnostics in #4, before the parsing-mode changes and final volatility correction.
  • Peter Eisentrautsaw an earlier versiontrailerReviewed the conversion component and argued for shared template semantics in #8 and #11, before the standard-mode implementation.
Implement standard datetime parsing mode
25 Sep 2019Alexander Korotkovmaster13beta1REL_19_STABLE13beta1REL_18_STABLE13beta1REL_17_STABLE13beta1REL_16_STABLE13beta1REL_15_STABLE13beta1REL_14_STABLE13beta1REL_13_STABLE13beta1
LLM analysis, 100% surelanded as postedfrom patchset #20

The standard-parsing component of #20 has identical added and removed lines in formatting.c, including STD_FLAG, strict separator matching, and mode-sensitive format caching.

Support for SSSSS datetime format pattern
16 Sep 2019Alexander Korotkovmaster13beta1REL_19_STABLE13beta1REL_18_STABLE13beta1REL_17_STABLE13beta1REL_16_STABLE13beta1REL_15_STABLE13beta1REL_14_STABLE13beta1REL_13_STABLE13beta1
LLM analysis, 100% surelanded as postedfrom patchset #180 of 2 reviewers saw the final version

Exactly matches the SSSSS component of #18, including the formatting.c alias, documentation, and horology regression cases; its landing is confirmed in #19.

  • Anastasia Lubennikovano review foundtrailerHer review in #4 predates the SSSSS addition, and the thread contains no subsequent review of that component by her.
  • Peter Eisentrautsaw an earlier versiontrailerIdentified the missing standard SSSSS template while reviewing #7 in #8, but did not visibly review the subsequently added implementation.
Support for FF1-FF6 datetime format patterns
16 Sep 2019Alexander Korotkovmaster13beta1REL_19_STABLE13beta1REL_18_STABLE13beta1REL_17_STABLE13beta1REL_16_STABLE13beta1REL_15_STABLE13beta1REL_14_STABLE13beta1REL_13_STABLE13beta1Also in: jsonpath (not this thread)
LLM analysis, 100% suremodified before commitlight changesfrom patchset #182 of 2 reviewers saw the final version

Matches the FF1–FF6 component of #18, with terminology changes in func.sgml and formatting.c comments documented in #19. The matching September patch is newer than the sources listed for thread #37997.

  • Anastasia Lubennikovasaw the final versiontrailerTested the conversion feature in #4, and the FF1–FF6 implementation subsequently underwent extraction and light editorial changes.
  • Peter Eisentrautsaw the final versiontrailerExamined FF1–FF6 correctness, precision tests, and terminology in #8, with the terminology recommendation incorporated before commit.

Credits across 7 commits

Author
Alexander Korotkov7
Nikita Glukhov6
Oleg Bartunov4
Teodor Sigaev4
Liudmila Mantrova2
Reviewer
Anastasia Lubennikova6
Peter Eisentraut6
Committer
Alexander Korotkov7