Quick doc typo fix
Issue found while translating the v12 manual. I also fixed something that
was missing, as far as I understand it (first fix, the typo is the second
fix).
See patch attached.
Thanks.
--
Guillaume.
Attachments:
typofix.patchtext/x-patch; charset=US-ASCII; name=typofix.patchDownload
diff --git a/doc/src/sgml/catalogs.sgml b/doc/src/sgml/catalogs.sgml
index 4c7e93892a..f81f3d4160 100644
--- a/doc/src/sgml/catalogs.sgml
+++ b/doc/src/sgml/catalogs.sgml
@@ -57,7 +57,7 @@
<row>
<entry><link linkend="catalog-pg-am"><structname>pg_am</structname></link></entry>
- <entry>index access methods</entry>
+ <entry>table and index access methods</entry>
</row>
<row>
diff --git a/doc/src/sgml/tablesample-method.sgml b/doc/src/sgml/tablesample-method.sgml
index 880e42c950..68eea68077 100644
--- a/doc/src/sgml/tablesample-method.sgml
+++ b/doc/src/sgml/tablesample-method.sgml
@@ -264,7 +264,7 @@ NextSampleTuple (SampleScanState *node,
requests to sample missing or invisible tuples; that should not result in
any bias in the sample. However, if necessary, the function can use
<literal>node->donetuples</literal> to examine how many of the tuples
- it returned were vlaid and visible.
+ it returned were valid and visible.
</para>
</note>
On Tue, May 28, 2019 at 05:05:10PM +0200, Guillaume Lelarge wrote:
<row> <entry><link linkend="catalog-pg-am"><structname>pg_am</structname></link></entry> - <entry>index access methods</entry> + <entry>table and index access methods</entry> </row>
Perhaps we could just say "relation" here? That's the term used on
the paragraph describing pg_am.
--
Michael
Le mar. 28 mai 2019 à 21:28, Michael Paquier <michael@paquier.xyz> a écrit :
On Tue, May 28, 2019 at 05:05:10PM +0200, Guillaume Lelarge wrote:
<row>
<entry><linklinkend="catalog-pg-am"><structname>pg_am</structname></link></entry>
- <entry>index access methods</entry> + <entry>table and index access methods</entry> </row>Perhaps we could just say "relation" here? That's the term used on
the paragraph describing pg_am.
Hehe, that was the first thing I wrote :) but went with "table and index"
as it was also used a bit later in the chapter. Both are fine with me.
--
Guillaume.
Le mar. 28 mai 2019 à 21:46, Guillaume Lelarge <guillaume@lelarge.info> a
écrit :
Le mar. 28 mai 2019 à 21:28, Michael Paquier <michael@paquier.xyz> a
écrit :On Tue, May 28, 2019 at 05:05:10PM +0200, Guillaume Lelarge wrote:
<row>
<entry><linklinkend="catalog-pg-am"><structname>pg_am</structname></link></entry>
- <entry>index access methods</entry> + <entry>table and index access methods</entry> </row>Perhaps we could just say "relation" here? That's the term used on
the paragraph describing pg_am.Hehe, that was the first thing I wrote :) but went with "table and index"
as it was also used a bit later in the chapter. Both are fine with me.
And here is another one. See patch attached.
--
Guillaume.
Attachments:
typofix_2.patchtext/x-patch; charset=US-ASCII; name=typofix_2.patchDownload
diff --git a/doc/src/sgml/file-fdw.sgml b/doc/src/sgml/file-fdw.sgml
index 2413089ffe..4c34ad9cc9 100644
--- a/doc/src/sgml/file-fdw.sgml
+++ b/doc/src/sgml/file-fdw.sgml
@@ -174,7 +174,7 @@
</variablelist>
<para>
- <command>COPY</command>'s <literal>FORCE_QUOTE</literal> options is
+ <command>COPY</command>'s <literal>FORCE_QUOTE</literal> option is
currently not supported by <literal>file_fdw</literal>.
</para>
On Tue, May 28, 2019 at 09:46:48PM +0200, Guillaume Lelarge wrote:
Hehe, that was the first thing I wrote :) but went with "table and index"
as it was also used a bit later in the chapter. Both are fine with me.
Okay, done this way. Thanks for the report.
--
Michael
On Wed, May 29, 2019 at 05:30:33PM +0200, Guillaume Lelarge wrote:
And here is another one. See patch attached.
Are you still going through some parts of the documentation? Perhaps
you may notice something else? I am wondering if it would be better
to wait a bit more so as we can group all issues you are finding at
once.
--
Michael
Le mer. 29 mai 2019 19:45, Michael Paquier <michael@paquier.xyz> a écrit :
On Wed, May 29, 2019 at 05:30:33PM +0200, Guillaume Lelarge wrote:
And here is another one. See patch attached.
Are you still going through some parts of the documentation? Perhaps
you may notice something else? I am wondering if it would be better
to wait a bit more so as we can group all issues you are finding at
once.
Yeah, I still have quite a lot to process. That might be better to do it
all in once.
On Wed, May 29, 2019 at 07:47:12PM +0200, Guillaume Lelarge wrote:
Yeah, I still have quite a lot to process. That might be better to do it
all in once.
OK, thanks! Could you ping me on this thread once you think you are
done?
--
Michael
Le mer. 29 mai 2019 19:52, Michael Paquier <michael@paquier.xyz> a écrit :
On Wed, May 29, 2019 at 07:47:12PM +0200, Guillaume Lelarge wrote:
Yeah, I still have quite a lot to process. That might be better to do it
all in once.OK, thanks! Could you ping me on this thread once you think you are
done?
Sure.
Hi Guillaume,
On Wed, May 29, 2019 at 08:28:59PM +0200, Guillaume Lelarge wrote:
Sure.
I have noticed your message on the French list about the completion of
the traduction, and congrats for that, it is a huge amount of work.
Did you find anything else after your last report?
--
Michael
On Sat, Jun 8, 2019 at 3:33 PM Michael Paquier <michael@paquier.xyz> wrote:
Hi Guillaume,
On Wed, May 29, 2019 at 08:28:59PM +0200, Guillaume Lelarge wrote:
Sure.
I have noticed your message on the French list about the completion of
the traduction, and congrats for that, it is a huge amount of work.
Did you find anything else after your last report?
It was the merge of upstream documentation completion in the french
repo, so the actual translation work can now begin. Probably there
will be more typo finding in the next weeks.
Le sam. 8 juin 2019 à 15:44, Julien Rouhaud <rjuju123@gmail.com> a écrit :
On Sat, Jun 8, 2019 at 3:33 PM Michael Paquier <michael@paquier.xyz>
wrote:Hi Guillaume,
On Wed, May 29, 2019 at 08:28:59PM +0200, Guillaume Lelarge wrote:
Sure.
I have noticed your message on the French list about the completion of
the traduction, and congrats for that, it is a huge amount of work.
Did you find anything else after your last report?
I have two more fixes. See attached patch.
It was the merge of upstream documentation completion in the french
repo, so the actual translation work can now begin. Probably there
will be more typo finding in the next weeks.
Yeah, only the merge is done. We now need to work on the actual
translation. But this is way more fun than the merge :)
We might find more typos, but it will take time. Applying this patch now
(if it fits you) is probably better.
--
Guillaume.
Attachments:
typofix_3.patchtext/x-patch; charset=US-ASCII; name=typofix_3.patchDownload
diff --git a/doc/src/sgml/file-fdw.sgml b/doc/src/sgml/file-fdw.sgml
index 2413089ffe..4c34ad9cc9 100644
--- a/doc/src/sgml/file-fdw.sgml
+++ b/doc/src/sgml/file-fdw.sgml
@@ -174,7 +174,7 @@
</variablelist>
<para>
- <command>COPY</command>'s <literal>FORCE_QUOTE</literal> options is
+ <command>COPY</command>'s <literal>FORCE_QUOTE</literal> option is
currently not supported by <literal>file_fdw</literal>.
</para>
diff --git a/doc/src/sgml/runtime.sgml b/doc/src/sgml/runtime.sgml
index e053e2ee34..323621b95c 100644
--- a/doc/src/sgml/runtime.sgml
+++ b/doc/src/sgml/runtime.sgml
@@ -753,7 +753,7 @@ psql: could not connect to server: No such file or directory
<row>
<entry><varname>SEMMNI</varname></entry>
<entry>Maximum number of semaphore identifiers (i.e., sets)</entry>
- <entry>at least <literal>ceil((max_connections + autovacuum_max_workers + wax_wal_senders + max_worker_processes + 5) / 16)</literal> plus room for other applications</entry>
+ <entry>at least <literal>ceil((max_connections + autovacuum_max_workers + max_wal_senders + max_worker_processes + 5) / 16)</literal> plus room for other applications</entry>
</row>
<row>
On Sat, Jun 08, 2019 at 04:23:55PM +0200, Guillaume Lelarge wrote:
We might find more typos, but it will take time. Applying this patch now
(if it fits you) is probably better.
I can imagine that it is a daunting task... Ok, for now I have
applied what you sent. Thanks!
--
Michael
Le dim. 9 juin 2019 à 04:27, Michael Paquier <michael@paquier.xyz> a écrit :
On Sat, Jun 08, 2019 at 04:23:55PM +0200, Guillaume Lelarge wrote:
We might find more typos, but it will take time. Applying this patch now
(if it fits you) is probably better.I can imagine that it is a daunting task... Ok, for now I have
applied what you sent. Thanks!
Thank you.
--
Guillaume.