model-writtenrun 9321 - may be wrong, links go to the source messages. Commit-by-commit LLM analysis is in the Commits dialog.
- Tom Lane discovered that hard-wired SQL_ASCII handling bypassed the ASCII↔MULE_INTERNAL and ASCII↔UTF8 conversion functions, and proposed removing them and rejecting new SQL_ASCII conversions in #1.
- Daniel Gustafsson raised a separate concern about dead functions and poor error handling in src/test/examples/testlo.c and testlo64.c in #2; that cleanup was not included in the submitted patch or candidate commit.
- Noah Misch explained that making the dormant functions reachable would impose inconsistent restrictions across encodings, considered broader validation alternatives, and supported deleting the dead functions in #3.
- Peter Eisentraut supported disallowing SQL_ASCII conversion definitions as semantically nonsensical in #4.
- Tom Lane posted the completed removal and rejection patch, with documentation and regression-test adjustments, in #5, saying it was too late for PostgreSQL 12 and proposing to commit after PostgreSQL 13 development opened; the thread ends at this submission without subsequent patch review.
- Tom Lane committed #5 on July 5, 2019 as 0ab1a2e39b, adding only a catalog-version bump beyond rebase differences, so the entire submitted change landed.