Jul 2019

2 commits
Fix missing calls to table_finish_bulk_insert during COPY, take 2
10 Jul 2019David Rowleymaster13beta1REL_19_STABLE13beta1REL_18_STABLE13beta1REL_17_STABLE13beta1REL_16_STABLE13beta1REL_15_STABLE13beta1REL_14_STABLE13beta1REL_13_STABLE13beta1+1 more
LLM analysis, 100% suremodified before commitmoderate changesfrom patchset #100 of 2 reviewers saw the final version

Retains #10's buffer-cleanup finish calls in src/backend/commands/copy.c, but moves cleanup before partition relations and executor state are released and removes the separate target-table finish call. David confirms the corrected cleanup order in #21.

  • Andres Freundsaw an earlier versionLLM analysis, 91% sureIn #13, Andres identified potentially expensive repeated fsync calls in the buffer-eviction approach of #10, before the later cleanup-order changes.
  • Michael Paquiersaw an earlier versionLLM analysis, 94% sureMichael criticized the executor callback structure in #15 and compared both implementations in #19, favoring the original copy.c approach before its cleanup order was corrected.
Fix missing call to table_finish_bulk_insert during COPY
1 Jul 2019David Rowleymaster12beta3REL_19_STABLE12beta3REL_18_STABLE12beta3REL_17_STABLE12beta3REL_16_STABLE12beta3REL_15_STABLE12beta3REL_14_STABLE12beta3REL_13_STABLE12beta3+1 more
LLM analysis, 100% suremodified before commitmoderate changesfrom patchset #100 of 2 reviewers saw the final version

Matches #10's buffer-cleanup implementation, with the target-table table_finish_bulk_insert call additionally guarded by insertMethod != CIM_SINGLE. David explicitly identifies this change when announcing the commit in #18.

  • Andres Freundsaw an earlier versionLLM analysis, 91% sureAndres identified repeated finish calls as potentially expensive in #13, reviewing #10 before the committed single-insert guard was added.
  • Michael Paquiersaw an earlier versionLLM analysis, 89% sureMichael challenged the extra executor callback layer in #15, reviewing the alternative #14 before David returned to the original implementation.

Credits across 2 commits

Author
David RowleyLLM2
Reported by
Robert Haas2
Committer
David Rowley2

N LLM means N of the credits come from LLM analysis, not from commit trailers.