Jun 2019

1 commit
Don't access catalogs to validate GUCs when not connected to a DB.
11 Jun 2019Andres Freundmaster12beta2REL_19_STABLE12beta2REL_18_STABLE12beta2REL_17_STABLE12beta2REL_16_STABLE12beta2REL_15_STABLE12beta2REL_14_STABLE12beta2REL_13_STABLE12beta2+6 more
LLM analysis, 100% suremodified before commitmoderate changesfrom patchset #10 of 2 reviewers saw the final version

The commit preserves the exact validation guard from #1, reorders its include, and expands the comments. Andres Freund also applies the guard to check_default_tablespace(), check_temp_tablespaces(), and check_TSCurrentConfig() in src/backend/commands/tablespace.c and src/backend/utils/cache/ts_cache.c, explaining the combined scope in #12.

  • Haribabu Kommisaw an earlier versionLLM analysis, 99% sureHaribabu reproduced the failure and confirmed that #1 fixed it in #2, before the commit expanded the fix to three additional validation hooks.
  • Dmitry Dolgovsaw an earlier versionLLM analysis, 92% sureReviewing the validation logic after #1, Dmitry identified the analogous default_tablespace problem and proposed the additional MyDatabaseId check in #5, which the commit incorporated.

Credits across 1 commit

Author
Andres Freund1
vignesh C1
Reported by
Andres Freund1
Michael Paquier1
vignesh C1
Committer
Andres Freund1