pg_checksums has an untranslatable string.

Started by Kyotaro Horiguchiover 6 years ago3 messages
#1Kyotaro Horiguchi
horikyota.ntt@gmail.com
1 attachment(s)

Hello.

# My email address has changed. Apologize in advance for possible
# duplicate of this mail because this is the seconf try after
# mail server seems to have failed the first try...

I found a string that ought to be translatable but actually not,
in pg_checksums.c.

fprintf(stderr, "%*s/%s MB (%d%%) computed",

It seems to be the only instance in the file.

regards.
--
Kyotaro Horiguchi
NTT Open Source Software Center

Attachments:

pg_checksums_fix_untranslatable_string.patchtext/x-patch; charset=us-asciiDownload
diff --git a/src/bin/pg_checksums/pg_checksums.c b/src/bin/pg_checksums/pg_checksums.c
index 1d75aa0282..7c7a75cdcd 100644
--- a/src/bin/pg_checksums/pg_checksums.c
+++ b/src/bin/pg_checksums/pg_checksums.c
@@ -146,7 +146,7 @@ progress_report(bool force)
 	snprintf(current_size_str, sizeof(current_size_str), INT64_FORMAT,
 			 current_size / (1024 * 1024));
 
-	fprintf(stderr, "%*s/%s MB (%d%%) computed",
+	fprintf(stderr, _("%*s/%s MB (%d%%) computed"),
 			(int) strlen(current_size_str), current_size_str, total_size_str,
 			percent);
 
#2Michael Paquier
michael@paquier.xyz
In reply to: Kyotaro Horiguchi (#1)
Re: pg_checksums has an untranslatable string.

On Thu, Jun 06, 2019 at 08:06:12PM +0900, Kyotaro Horiguchi wrote:

It seems to be the only instance in the file.

Confirmed and committed. Thanks for the report.
--
Michael

#3Horiguchi Kyotaro
horikyota.ntt@gmail.com
In reply to: Michael Paquier (#2)
Re: pg_checksums has an untranslatable string.

Hello

Confirmed and committed. Thanks for the report.

Thanks for committing.
--
Kyotaro Horiguchi
NTT Open Source Software Center