model-writtenrun 9252 - may be wrong, links go to the source messages. Commit-by-commit LLM analysis is in the Commits dialog.
- Alvaro Herrera reported that seawasp failed to compile against experimental LLVM 9 #1; didier traced the failure to PostgreSQL's Min macro colliding with LLVM's ElementCount member #3, and Fabien confirmed that seawasp rebuilt LLVM from development sources weekly #4.
- Tom Lane initially favored waiting for LLVM to reconsider the conflicting name #5, but Thomas Munro later reported that the change had reached LLVM's release_90 branch #6.
- Fabien proposed reporting the issue upstream or renaming PostgreSQL's macro #7; Thomas instead proposed undefining Min where LLVM C++ headers were included #8 and posted a patch that fixed his LLVM 9 build #9.
- Fabien warned that PostgreSQL headers could still need Min and suggested moving LLVM includes ahead of PostgreSQL includes #10; Tom rejected that ordering because postgres.h establishes configuration macros needed by system headers #11, leaving Fabien's concerns about the workaround on record #12.
- Thomas chose the small #undef workaround to restore seawasp's usefulness, allowing for a possible revert if LLVM changed before release #13, and Tom agreed #14.
- Thomas committed #9 as a2a777d011, moving the #undef immediately before LLVM's C++ headers and clarifying its comment, with backpatching through PostgreSQL 11; he announced completion in #15.
- The thread closed with Fabien confirming that seawasp was green again #17, with the fix committed and no further patch pending.