Wording variations in descriptions of gucs.
Started by Kyotaro Horiguchiover 6 years ago1 messages
Hello.
In guc.c many of the variables are described as "Set_s_ something"
as if the variable name is the omitted subject. A few seem being
wrongly written as "Set something" with the same intention.
Is it useful to unify them to the majority?
wal_level
gettext_noop("Set the level of information written to the WAL."),
log_transaction_sample_rage
gettext_noop("Set the fraction of transactions to log for new transactions."),
Though, recovery_target seems written as intended.
gettext_noop("Set to 'immediate' to end recovery as soon as a consistent state is reached.
# rather it seems to be the detaied description..
regards.
--
Kyotaro Horiguchi
NTT Open Source Software Center
Attachments:
guc_desc_fix.patchapplication/octet-stream; name=guc_desc_fix.patchDownload
diff --git a/src/backend/utils/misc/guc.c b/src/backend/utils/misc/guc.c
index 1208eb9a68..4cd1eed431 100644
--- a/src/backend/utils/misc/guc.c
+++ b/src/backend/utils/misc/guc.c
@@ -3446,7 +3446,7 @@ static struct config_real ConfigureNamesReal[] =
{
{"log_transaction_sample_rate", PGC_SUSET, LOGGING_WHEN,
- gettext_noop("Set the fraction of transactions to log for new transactions."),
+ gettext_noop("Sets the fraction of transactions to log for new transactions."),
gettext_noop("Logs all statements from a fraction of transactions. "
"Use a value between 0.0 (never log) and 1.0 (log all "
"statements for all transactions).")
@@ -4422,7 +4422,7 @@ static struct config_enum ConfigureNamesEnum[] =
{
{"wal_level", PGC_POSTMASTER, WAL_SETTINGS,
- gettext_noop("Set the level of information written to the WAL."),
+ gettext_noop("Sets the level of information written to the WAL."),
NULL
},
&wal_level,