ReplicationSlotCtl: undefined reference
Greetings.
Trying to build pg extension I've got error:
```
pglogical_monitoring.o:pglogical_monitoring.c:(.rdata$.refptr.ReplicationSlotCtl[.refptr.ReplicationSlotCtl]+0x0): undefined reference to `ReplicationSlotCtl'
collect2: error: ld returned 1 exit status
```
But according to https://commitfest.postgresql.org/16/1390/ it should
be marked with PGDLLIMPORT.
However checking sources there is no this spec
(https://github.com/postgres/postgres/blob/fff2a7d7bd09db38e1bafc1303c29b10a9805dc0/src/include/replication/slot.h#L172):
```
extern ReplicationSlotCtlData *ReplicationSlotCtl;
```
Am I correct or missing smth?
Craig, it supposed to be your proposal about ReplicationSlotCtl and
patch. Am I right?
--
Kind regards,
Pavlo mailto:pavlo.golub@cybertec.at
Pavlo Golub <pavlo.golub@cybertec.at> writes:
Trying to build pg extension I've got error:
```
pglogical_monitoring.o:pglogical_monitoring.c:(.rdata$.refptr.ReplicationSlotCtl[.refptr.ReplicationSlotCtl]+0x0): undefined reference to `ReplicationSlotCtl'
collect2: error: ld returned 1 exit status
```
But according to https://commitfest.postgresql.org/16/1390/ it should
be marked with PGDLLIMPORT.
That last bit never actually got pushed, it seems. Done now.
regards, tom lane
<div dir='auto'><div><br><div class="gmail_extra"><br><div class="gmail_quote">On Jun 13, 2019 17:56, Tom Lane <tgl@sss.pgh.pa.us> wrote:<br type="attribution"><blockquote class="quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><p dir="ltr">Pavlo Golub <pavlo.golub@cybertec.at> writes:
<br>
> Trying to build pg extension I've got error:
<br>
> ```
<br>
> pglogical_monitoring.o:pglogical_monitoring.c:(.rdata$.refptr.ReplicationSlotCtl[.refptr.ReplicationSlotCtl]+0x0): undefined reference to `ReplicationSlotCtl'
<br>
> collect2: error: ld returned 1 exit status
<br>
> ```
<br>
<br>
> But according to https://commitfest.postgresql.org/16/1390/ it should
<br>
> be marked with PGDLLIMPORT.
<br>
<br>
That last bit never actually got pushed, it seems. Done now.
<br></p></blockquote></div></div></div><div dir="auto"><br></div><div dir="auto">Thanks Tom. Really appreciate that!</div><div dir="auto"><div class="gmail_extra"><div class="gmail_quote"><blockquote class="quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><p dir="ltr">
<br>
regards, tom lane
<br>
</p>
</blockquote></div><br></div></div></div>