Jun 2019

2 commits
pg_upgrade: Improve invalid option handling
19 Jun 2019Peter Eisentrautmaster12beta3REL_19_STABLE12beta3REL_18_STABLE12beta3REL_17_STABLE12beta3REL_16_STABLE12beta3REL_15_STABLE12beta3REL_14_STABLE12beta3REL_13_STABLE12beta3+1 more
LLM analysis, 100% surelanded as postedfrom patchset #11 of 1 reviewer saw the final version

All three hunks in src/bin/pg_upgrade/option.c match #1, including delayed log creation, delayed verbose reporting, and fprintf(stderr) plus exit(1) for invalid options.

  • Masahiko Sawadasaw the final versionLLM analysis, 92% sureMasahiko Sawada questioned the apparently unnecessary replacement of pg_fatal() in #2, prompting the explanation of its output effects in #3; the reviewed code landed unchanged.
pg_upgrade: Improve error messages
19 Jun 2019Peter Eisentrautmaster12beta3REL_19_STABLE12beta3REL_18_STABLE12beta3REL_17_STABLE12beta3REL_16_STABLE12beta3REL_15_STABLE12beta3REL_14_STABLE12beta3REL_13_STABLE12beta3+1 more
LLM analysis, 100% surewritten from the discussion, no matching patch

The four diagnostic changes in src/bin/pg_upgrade/exec.c and option.c implement Daniel Gustafsson's wording suggestion #4 and Michael Paquier's request for system error details and identification of four affected strings #5 #7. No attached patch contains these changes; Peter Eisentraut confirmed committing them separately in #8.

Credits across 2 commits

Author
Peter EisentrautLLM1
Committer
Peter Eisentraut2

N LLM means N of the credits come from LLM analysis, not from commit trailers.