Sep 2019

2 commits
Better error messages for short reads/writes in SLRU
3 Sep 2019Peter Eisentrautmaster13beta1REL_19_STABLE13beta1REL_18_STABLE13beta1REL_17_STABLE13beta1REL_16_STABLE13beta1REL_15_STABLE13beta1REL_14_STABLE13beta1REL_13_STABLE13beta1+1 more
LLM analysis, 100% surelanded as postedfrom patchset #41 of 1 reviewer saw the final version

The SLRU patch in #4 matches the committed diff in src/backend/access/transam/slru.c, including separate errno branches and the read/wrote-too-few-bytes diagnostics.

  • Michael Paquiersaw the final versiontrailerHe identified the unnecessary errcode_for_file_access() call in #3 and accepted the revised SLRU diagnostics after discussing their formatting in #5.
pg_checksums: Handle read and write returns correctly
3 Sep 2019Peter Eisentrautmaster13beta1REL_19_STABLE13beta1REL_18_STABLE13beta1REL_17_STABLE13beta1REL_16_STABLE13beta1REL_15_STABLE13beta1REL_14_STABLE13beta1REL_13_STABLE13beta1+1 more
LLM analysis, 100% suremodified before commitmoderate changesfrom patchset #41 of 1 reviewer saw the final version

The pg_checksums patch in #4 supplies the read-error and short-write handling; the commit nests the negative-read check inside the r != BLCKSZ branch as Michael Paquier requested in #5. The write-handling changes are unchanged.

  • Michael Paquiersaw the final versiontrailerIn #5, he reviewed the pg_checksums error handling and supplied the precise read-check structure used in the committed version.

Jul 2019

1 commit
Use consistent style for checking return from system calls
7 Jul 2019Peter Eisentrautmaster13beta1REL_19_STABLE13beta1REL_18_STABLE13beta1REL_17_STABLE13beta1REL_16_STABLE13beta1REL_15_STABLE13beta1REL_14_STABLE13beta1REL_13_STABLE13beta1
LLM analysis, 99% suremodified before commitmoderate changesfrom patchset #10 of 1 reviewer saw the final version

The second patch in #1 changes five SLRU checks to < 0; the commit instead uses != 0 and expands the cleanup to 45 checks across 19 files. This incorporates Michael Paquier's observation in #3 that many CloseTransientFile sites were missing.

  • Michael Paquiersaw an earlier versionLLM analysis, 96% sureIn #3, he inspected the return-check patch and identified omitted CloseTransientFile sites, prompting the broader cleanup whose final expanded diff was not posted.

Credits across 3 commits

Author
Peter EisentrautLLM3
Reviewer
Michael Paquier2
Committer
Peter Eisentraut3

N LLM means N of the credits come from LLM analysis, not from commit trailers.