Some reloptions non-initialized when loaded
Started by Michael Paquierover 6 years ago2 messages
Hi all,
While looking at this code, I have noticed that a couple of reloptions
which are not toast-specific don't get properly initialized.
toast_tuple_target and parallel_workers are the ones standing out.
Thoughts?
--
Michael
Attachments:
relopts-init.patchtext/x-diff; charset=us-asciiDownload
diff --git a/src/backend/access/common/reloptions.c b/src/backend/access/common/reloptions.c
index de06c92574..02ea6f748f 100644
--- a/src/backend/access/common/reloptions.c
+++ b/src/backend/access/common/reloptions.c
@@ -1482,6 +1482,8 @@ heap_reloptions(char relkind, Datum reloptions, bool validate)
rdopts->fillfactor = 100;
rdopts->autovacuum.analyze_threshold = -1;
rdopts->autovacuum.analyze_scale_factor = -1;
+ rdopts->parallel_workers = -1;
+ rdopts->toast_tuple_target = TOAST_TUPLE_TARGET;
}
return (bytea *) rdopts;
case RELKIND_RELATION:
Re: Some reloptions non-initialized when loaded
Hello,
On Wed, Jun 19, 2019 at 10:23 AM Michael Paquier <michael@paquier.xyz> wrote:
Hi all,
While looking at this code, I have noticed that a couple of reloptions
which are not toast-specific don't get properly initialized.
toast_tuple_target and parallel_workers are the ones standing out.
Do we also need to initialize vacuum_cleanup_index_scale_factor?
--
Thanks & Regards,
Kuntal Ghosh
EnterpriseDB: http://www.enterprisedb.com