Remove one last occurrence of "replication slave" in comments

Started by Daniel Gustafssonalmost 7 years ago5 messageshackers
Jump to latest
#1Daniel Gustafsson
daniel@yesql.se

A Twitter thread today regarding the use of master/slave [1]https://twitter.com/Xof/status/1141040942645776384 made me curious
and so I had a look. It seems that commit a1ef920e27ba6ab3602aaf6d6751d8628
replaced most instances but missed at least one which is fixed in the attached.

cheers ./daniel

[1]: https://twitter.com/Xof/status/1141040942645776384

Attachments:

slave_comment.patchapplication/octet-stream; name=slave_comment.patch; x-unix-mode=0644Download+1-2
#2Magnus Hagander
magnus@hagander.net
In reply to: Daniel Gustafsson (#1)
Re: Remove one last occurrence of "replication slave" in comments

On Wed, Jun 19, 2019 at 2:35 PM Daniel Gustafsson <daniel@yesql.se> wrote:

A Twitter thread today regarding the use of master/slave [1] made me
curious
and so I had a look. It seems that commit
a1ef920e27ba6ab3602aaf6d6751d8628
replaced most instances but missed at least one which is fixed in the
attached.

Applied, thanks.

--
Magnus Hagander
Me: https://www.hagander.net/ <http://www.hagander.net/&gt;
Work: https://www.redpill-linpro.com/ <http://www.redpill-linpro.com/&gt;

In reply to: Daniel Gustafsson (#1)
Re: Remove one last occurrence of "replication slave" in comments

Daniel Gustafsson <daniel@yesql.se> writes:

A Twitter thread today regarding the use of master/slave [1] made me curious
and so I had a look. It seems that commit a1ef920e27ba6ab3602aaf6d6751d8628
replaced most instances but missed at least one which is fixed in the attached.

cheers ./daniel

There were some more master/slave references in the plpgsql foreign key
tests, which the attached chages to base/leaf instead.

I didn't touch the last mention of "slave", in the pltcl code, because
it's calling the Tcl_CreateSlave() API function.

- ilmari
--
"The surreality of the universe tends towards a maximum" -- Skud's Law
"Never formulate a law or axiom that you're not prepared to live with
the consequences of." -- Skud's Meta-Law

Attachments:

0001-Remove-master-slave-usage-from-plpgsql-tests.patchtext/x-diffDownload+18-19
#4Peter Eisentraut
peter_e@gmx.net
In reply to: Dagfinn Ilmari Mannsåker (#3)
Re: Remove one last occurrence of "replication slave" in comments

On 2019-06-19 19:04, Dagfinn Ilmari Mannsåker wrote:

There were some more master/slave references in the plpgsql foreign key
tests, which the attached chages to base/leaf instead.

base/leaf doesn't sound like a good pair. I committed it with root/leaf
instead.

--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

In reply to: Peter Eisentraut (#4)
Re: Remove one last occurrence of "replication slave" in comments

Peter Eisentraut <peter.eisentraut@2ndquadrant.com> writes:

On 2019-06-19 19:04, Dagfinn Ilmari Mannsåker wrote:

There were some more master/slave references in the plpgsql foreign key
tests, which the attached chages to base/leaf instead.

base/leaf doesn't sound like a good pair. I committed it with root/leaf
instead.

Thanks! You're right, that is a better name pair.

- ilmari
--
"A disappointingly low fraction of the human race is,
at any given time, on fire." - Stig Sandbeck Mathisen