Nov 2019

3 commits
Remove any-user DML capability from allow_system_table_mods
29 Nov 2019Peter Eisentrautmaster13beta1REL_19_STABLE13beta1REL_18_STABLE13beta1REL_17_STABLE13beta1REL_16_STABLE13beta1REL_15_STABLE13beta1REL_14_STABLE13beta1REL_13_STABLE13beta1
LLM analysis, 100% surelanded as postedfrom patchset #231 of 1 reviewer saw the final version

Both hunks in src/backend/catalog/aclchk.c match the first patch in #23, removing the allowSystemTableMods exception from pg_class_aclmask and updating its comment.

  • Tom Lanesaw the final versiontrailerTom explicitly reviewed the complete patchset in #24 and raised no objection to the ACL change.
Make allow_system_table_mods settable at run time
29 Nov 2019Peter Eisentrautmaster13beta1REL_19_STABLE13beta1REL_18_STABLE13beta1REL_17_STABLE13beta1REL_16_STABLE13beta1REL_15_STABLE13beta1REL_14_STABLE13beta1REL_13_STABLE13beta1
LLM analysis, 100% suremodified before commitlight changesfrom patchset #231 of 1 reviewer saw the final version

The second patch in #23 matches the committed PGC_POSTMASTER-to-PGC_SUSET change in src/backend/utils/misc/guc.c. Only doc/src/sgml/config.sgml differs: the commit replaces “Inconsiderate” with “Ill-advised” and removes the initdb sentence, as requested in #24.

  • Tom Lanesaw the final versiontrailerTom reviewed the complete patchset and proposed both documentation adjustments adopted by the commit in #24.
Add a regression test for allow_system_table_mods
29 Nov 2019Peter Eisentrautmaster13beta1REL_19_STABLE13beta1REL_18_STABLE13beta1REL_17_STABLE13beta1REL_16_STABLE13beta1REL_15_STABLE13beta1REL_14_STABLE13beta1REL_13_STABLE13beta1
LLM analysis, 100% surelanded as postedfrom patchset #231 of 1 reviewer saw the final version

The commit matches the third patch in #23: the unsafe_tests Makefile registration, new SQL and expected output, and obsolete-comment removal from the existing alter_table tests all match after normalizing diff metadata.

  • Tom Lanesaw the final versiontrailerTom explicitly reported reading the complete patchset in #24, with his only requested changes concerning the accompanying documentation.

Credits across 3 commits

Author
Peter EisentrautLLM3
Reviewer
Tom Lane3
Committer
Peter Eisentraut3

N LLM means N of the credits come from LLM analysis, not from commit trailers.