Jul - Aug 2019

3 commits
Add an isolation test to exercise parallel-worker deadlock resolution.
1 Aug 2019Tom Lanemaster13beta1REL_19_STABLE13beta1REL_18_STABLE13beta1REL_17_STABLE13beta1REL_16_STABLE13beta1REL_15_STABLE13beta1REL_14_STABLE13beta1REL_13_STABLE13beta1
LLM analysis, 99% suremodified before commitlight changesfrom patchset #131 of 1 reviewer saw the final version

The commit preserves the advisory-lock deadlock scenario from #13, installs it as a separate deadlock-parallel test, and adds it to isolation_schedule. It removes the empty guard and its callers from lockfuncs.c, drops unnecessary IMMUTABLE markings and an unused test column, and adjusts comments, formatting and the test timeout.

  • Robert Haassaw the final versionLLM analysis, 90% sureRobert examined the consequences of disabling advisory-lock checks, identified same-group mutual-exclusion concerns in #21, and assessed crash risk before accepting the change in #23 and #27.
Mark advisory-lock functions as parallel restricted, not parallel unsafe.
1 Aug 2019Tom Lanemaster13beta1REL_19_STABLE13beta1REL_18_STABLE13beta1REL_17_STABLE13beta1REL_16_STABLE13beta1REL_15_STABLE13beta1REL_14_STABLE13beta1REL_13_STABLE13beta1
LLM analysis, 100% surewritten from the discussion, no matching patch

Neither attachment changes advisory-lock catalog markings; Tom proposed parallel-restricted labeling in #20 and explained the required leader-only lock lifetime in #22. The commit changes proparallel from unsafe to restricted in src/include/catalog/pg_proc.dat and bumps catversion.h.

Fix busted logic for parallel lock grouping in TopoSort().
29 Jul 2019Tom Lanemaster13beta1REL_19_STABLE13beta1REL_18_STABLE13beta1REL_17_STABLE13beta1REL_16_STABLE13beta1REL_15_STABLE13beta1REL_14_STABLE13beta1REL_13_STABLE13beta1+4 more
LLM analysis, 100% suremodified before commitlight changesfrom patchset #11 of 1 reviewer saw the final version

The commit contains the exact break removal from #1 in src/backend/storage/lmgr/deadlock.c. Tom additionally documents consistent lock-group representative selection and asserts that beforeConstraints[jj] is nonnegative.

  • Tom Lanesaw the final versioncommittercommitted the patch

Credits across 3 commits

Author
Rui Hai JiangLLM1
Tom LaneLLM1
Reviewer
Tom Lanecommitter1
Committer
Tom Lane3

N LLM means N of the credits come from LLM analysis, not from commit trailers.