doc: minor update for description of "pg_roles" view

Started by Ian Barwickover 6 years ago3 messages
#1Ian Barwick
ian.barwick@2ndquadrant.com
1 attachment(s)

Hi

Here:

https://www.postgresql.org/docs/12/view-pg-roles.html

we state:

"This view explicitly exposes the OID column of the underlying table,
since that is needed to do joins to other catalogs."

I think it's superfluous to mention this now OIDs are exposed by default;
attached patch (for REL_12_STABLE and HEAD) simply removes this sentence.

Regards

Ian Barwick

--
Ian Barwick https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services

Attachments:

view-pg_roles.v1.patchtext/x-patch; name=view-pg_roles.v1.patchDownload
diff --git a/doc/src/sgml/catalogs.sgml b/doc/src/sgml/catalogs.sgml
new file mode 100644
index 3428a7c..68ad507
*** a/doc/src/sgml/catalogs.sgml
--- b/doc/src/sgml/catalogs.sgml
*************** SELECT * FROM pg_locks pl LEFT JOIN pg_p
*** 9995,10005 ****
     that blanks out the password field.
    </para>
  
-   <para>
-    This view explicitly exposes the OID column of the underlying table,
-    since that is needed to do joins to other catalogs.
-   </para>
- 
    <table>
     <title><structname>pg_roles</structname> Columns</title>
  
--- 9995,10000 ----
#2Bruce Momjian
bruce@momjian.us
In reply to: Ian Barwick (#1)
Re: doc: minor update for description of "pg_roles" view

On Wed, Jul 10, 2019 at 02:35:56PM +0900, Ian Barwick wrote:

Hi

Here:

https://www.postgresql.org/docs/12/view-pg-roles.html

we state:

"This view explicitly exposes the OID column of the underlying table,
since that is needed to do joins to other catalogs."

I think it's superfluous to mention this now OIDs are exposed by default;
attached patch (for REL_12_STABLE and HEAD) simply removes this sentence.

Patch applied though PG 12. Thanks.

--
Bruce Momjian <bruce@momjian.us> http://momjian.us
EnterpriseDB http://enterprisedb.com

+ As you are, so once was I.  As I am, so you will be. +
+                      Ancient Roman grave inscription +
#3Ian Barwick
ian.barwick@2ndquadrant.com
In reply to: Bruce Momjian (#2)
Re: doc: minor update for description of "pg_roles" view

On 7/11/19 3:24 AM, Bruce Momjian wrote:

On Wed, Jul 10, 2019 at 02:35:56PM +0900, Ian Barwick wrote:

Hi

Here:

https://www.postgresql.org/docs/12/view-pg-roles.html

we state:

"This view explicitly exposes the OID column of the underlying table,
since that is needed to do joins to other catalogs."

I think it's superfluous to mention this now OIDs are exposed by default;
attached patch (for REL_12_STABLE and HEAD) simply removes this sentence.

Patch applied though PG 12. Thanks.

Thanks!

Regards

Ian Barwick

--
Ian Barwick https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services