make clean removes excesively

Started by Kyotaro Horiguchiover 7 years ago2 messageshackers
Beta feature

Hackorum builds and tests every patch posted to the lists, not only commitfest submissions. This is Hackorum's own CI rather than the PostgreSQL project's, and it is still under testing - please report anything that looks wrong.

appliessuccessCI history

You can run a PostgreSQL built from this patch straight from Docker, with no checkout and no build:

docker run --rm -p 5432:5432 ghcr.io/hackorum-dev/postgres-patch:t40907
psql -h localhost -U postgres

Built from patchset v1 (message #1), October 23, 2026 at 01:22 AM.

Every patchset is also pushed to a branch of our PostgreSQL fork, so you can check out the same tree CI built. Without a PostgreSQL checkout:

git clone --branch t40907_1 https://github.com/hackorum-dev/postgres.git

In a checkout you already have, add the fork once:

git remote add hackorum https://github.com/hackorum-dev/postgres.git

then, for this patchset and every later one:

git fetch hackorum t40907_1 && git checkout t40907_1

Patchset v1 (message #1) is on t40907_1

Jump to latest
#1Kyotaro Horiguchi
horikyota.ntt@gmail.com

I found the following make's behavior is annoying (at dab81b9953).

make distclean
./configure ....
make all
<succeeds>
make -j4 clean all
relpath.c:21:10: fatal error: catalog/pg_tablespace_d.h: No such file or directory
#include "catalog/pg_tablespace_d.h"

(-j is needed, this happnes for me by -j2)

Just fixing the Makefile for it reveals the next complainer.

I'm not sure that it's the right thing but make got quiet by
moving include to the top in SUBDIRS in src/Makefile.

regards.

--
Kyotaro Horiguchi
NTT Open Source Software Center

Attachments:

t40907_1
0001-Make-src-include-first.patchtext/x-patch; charset=us-asciiDownload+2-2
#2Kyotaro Horiguchi
horikyota.ntt@gmail.com
In reply to: Kyotaro Horiguchi (#1)
make -jn fails by requiring not-yet-generated include files.

Sorry, the subject of the previous mail was wrong. I resend it
with the correct subject.

====
I found the following make's behavior is annoying (at dab81b9953).

make distclean
./configure ....
make all
<succeeds>
make -j4 clean all
relpath.c:21:10: fatal error: catalog/pg_tablespace_d.h: No such file or directory
#include "catalog/pg_tablespace_d.h"

(-j is needed, this happnes for me by -j2)

Just fixing the Makefile for it reveals the next complainer.

I'm not sure that it's the right thing but make got quiet by
moving include to the top in SUBDIRS in src/Makefile.

regards.

--
Kyotaro Horiguchi
NTT Open Source Software Center