Oct 2020

8 commits
Fix initialization of es_result_relations in EvalPlanQualStart().
23 Oct 2020Heikki Linnakangasmaster14beta1REL_19_STABLE14beta1REL_18_STABLE14beta1REL_17_STABLE14beta1REL_16_STABLE14beta1REL_15_STABLE14beta1REL_14_STABLE14beta1
LLM analysis, 100% surepart of a posted patchsetlight changesfrom patchset #741 of 1 reviewer saw the final version

Takes only the first patch of the three-patch series #74; its execMain.c change has an identical stable patch ID. The correction initializes rcestate->es_result_relations instead of resetting parentestate.

  • Heikki Linnakangassaw the final versioncommittercommitted the patch
Remove PartitionRoutingInfo struct.
19 Oct 2020Heikki Linnakangasmaster14beta1REL_19_STABLE14beta1REL_18_STABLE14beta1REL_17_STABLE14beta1REL_16_STABLE14beta1REL_15_STABLE14beta1REL_14_STABLE14beta1
LLM analysis, 99% surepart of a posted patchsetlight changesfrom patchset #691 of 2 reviewers saw the final version

Takes the second member of #69, moving PartitionRoutingInfo fields into ResultRelInfo. Differences are comment formatting and an equivalent simplification of the is_leaf assignment in ExecFindPartition.

  • Alvaro Herrerasaw an earlier versiontrailerReviewed the preceding structure and initialization design in #66 and supported removing the structure in #68, but no review of the subsequently attached removal patch is shown.
  • Heikki Linnakangassaw the final versioncommittercommitted the patch
Revise child-to-root tuple conversion map management.
19 Oct 2020Heikki Linnakangasmaster14beta1REL_19_STABLE14beta1REL_18_STABLE14beta1REL_17_STABLE14beta1REL_16_STABLE14beta1REL_15_STABLE14beta1REL_14_STABLE14beta1
LLM analysis, 99% surepart of a posted patchsetlight changesfrom patchset #692 of 3 reviewers saw the final version

Takes the conversion-map member of #69, with comment edits, explicit ri_ChildToRootMap initialization and adaptation to the separately committed rootResultRelInfo cleanup. The PartitionRoutingInfo removal landed separately.

  • Andres Freundsaw an earlier versionLLM analysis, 98% sureQuestioned map ownership and the is_update_result_rel test in #16, leading to revisions before the later consolidation of both conversion maps.
  • Alvaro Herrerasaw the final versionLLM analysis, 96% sureExamined conversion-map placement and ExecInitRoutingInfo initialization paths in #66 and #68, after which this series member received only light changes.
  • Heikki Linnakangassaw the final versioncommittercommitted the patch
Clean up code to resolve the "root target relation" in nodeModifyTable.c
19 Oct 2020Heikki Linnakangasmaster14beta1REL_19_STABLE14beta1REL_18_STABLE14beta1REL_17_STABLE14beta1REL_16_STABLE14beta1REL_15_STABLE14beta1REL_14_STABLE14beta1
LLM analysis, 100% surewritten from the discussion, no matching patch

No attachment contains this standalone removal of getTargetResultRelInfo and unconditional initialization of rootResultRelInfo. Heikki identifies it as his additional cleanup while committing the series in #70.

Refactor code for cross-partition updates to a separate function.
15 Oct 2020Heikki Linnakangasmaster14beta1REL_19_STABLE14beta1REL_18_STABLE14beta1REL_17_STABLE14beta1REL_16_STABLE14beta1REL_15_STABLE14beta1REL_14_STABLE14beta1
LLM analysis, 100% surepart of a posted patchsetmoderate changesfrom patchset #521 of 3 reviewers saw the final version

Extracts ExecCrossPartitionUpdate from the fourth member of #52, with comment editing and formatting. Heikki explicitly omitted its AFTER ROW INSERT/DELETE trigger-call restructuring in #64.

  • Andres Freundsaw an earlier versionLLM analysis, 98% sureReviewed the implementation in #7, requesting the ExecCrossPartitionUpdate name and clearer boolean arguments before subsequent return-convention and scope changes.
  • Alvaro Herrerasaw an earlier versionLLM analysis, 98% sureIdentified the inverted success return convention in #8, which Amit changed in #10.
  • Heikki Linnakangassaw the final versioncommittercommitted the patch
Remove es_result_relation_info from EState.
14 Oct 2020Heikki Linnakangasmaster14beta1REL_19_STABLE14beta1REL_18_STABLE14beta1REL_17_STABLE14beta1REL_16_STABLE14beta1REL_15_STABLE14beta1REL_14_STABLE14beta1
LLM analysis, 100% surepart of a posted patchsetlight changesfrom patchset #601 of 2 reviewers saw the final version

Takes the second member of Heikki's repost #60, removing es_result_relation_info and passing ResultRelInfo explicitly through executor and replication calls. Changes to that member are comments and formatting; the patch and commit credit Amit Langote.

  • Andres Freundsaw an earlier versionLLM analysis, 95% sureReviewed the remaining global-state dependencies, argument annotations and replication handling in #7, before the patch expanded from reducing usage to removing the field.
  • Heikki Linnakangassaw the final versioncommittercommitted the patch
Include result relation info in direct modify ForeignScan nodes.
14 Oct 2020Heikki Linnakangasmaster14beta1REL_19_STABLE14beta1REL_18_STABLE14beta1REL_17_STABLE14beta1REL_16_STABLE14beta1REL_15_STABLE14beta1REL_14_STABLE14beta1
LLM analysis, 100% surepart of a posted patchsetlight changesfrom patchset #601 of 2 reviewers saw the final version

Takes the first member of #60, matching its ForeignScan.resultRelation and ForeignScanState.resultRelInfo changes modulo whitespace; the deferred-initialization delta #61 was explicitly excluded. The patch and commit credit both Amit Langote and Etsuro Fujita, whose alternative implementation appears in #15.

  • Andres Freundsaw an earlier versionLLM analysis, 99% sureCritiqued the BeginDirectModify relocation and linear lookup in #16 and #18, then supported the less restrictive setrefs implementation in #31 before the later RT-index redesign.
  • Heikki Linnakangassaw the final versioncommittercommitted the patch
Create ResultRelInfos later in InitPlan, index them by RT index.
13 Oct 2020Heikki Linnakangasmaster14beta1REL_19_STABLE14beta1REL_18_STABLE14beta1REL_17_STABLE14beta1REL_16_STABLE14beta1REL_15_STABLE14beta1REL_14_STABLE14beta1
LLM analysis, 100% suremodified before commitmoderate changesfrom patchset #551 of 1 reviewer saw the final version

Derived from Heikki's consolidated repost #55, which credits Amit. Following #56, the commit retains PlannedStmt.resultRelations, merges root entries into it, restores list-based ExecRelationIsTargetRelation and removes an unnecessary TRUNCATE allocation.

  • Heikki Linnakangassaw the final versioncommittercommitted the patch

Credits across 8 commits

Author
Amit Langote1 LLM7
Reviewer
Heikki Linnakangascommitter7
Alvaro Herrera1
Committer
Heikki Linnakangas8

N LLM means N of the credits come from LLM analysis, not from commit trailers.