Is ParsePrepareRecord dead function
Hackorum builds and tests every patch posted to the lists, not only commitfest submissions. This is Hackorum's own CI rather than the PostgreSQL project's, and it is still under testing - please report anything that looks wrong.
You can run a PostgreSQL built from this patch straight from Docker, with no checkout and no build:
docker run --rm -p 5432:5432 ghcr.io/hackorum-dev/postgres-patch:t40996psql -h localhost -U postgresBuilt from patchset v3 (message #3), July 28, 2026 at 01:28 PM.
Every patchset is also pushed to a branch of our PostgreSQL fork, so you can check out the same tree CI built. Without a PostgreSQL checkout:
git clone --branch t40996_3 https://github.com/hackorum-dev/postgres.gitIn a checkout you already have, add the fork once:
git remote add hackorum https://github.com/hackorum-dev/postgres.gitthen, for this patchset and every later one:
git fetch hackorum t40996_3 && git checkout t40996_3Patchset v3 (message #3) is on t40996_3
Hi,
I could not locate the caller of ParsePrepareRecord function in twophase.c.
Any idea how it gets called?
or
Is it a dead function?
Regards,
Vignesh
EnterpriseDB: http://www.enterprisedb.com
On Mon, Jul 29, 2019 at 4:10 AM vignesh C <vignesh21@gmail.com> wrote:
I could not locate the caller of ParsePrepareRecord function in twophase.c.
Any idea how it gets called?
or
Is it a dead function?
It looks like it's not only dead, but stillborn. Commit
1eb6d6527aae264b3e0b9c95aa70bb7a594ad1cf introduced it but without
introducing any code that called it, and nothing has changed since
then.
--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
On Mon, Jul 29, 2019 at 8:24 PM Robert Haas <robertmhaas@gmail.com> wrote:
On Mon, Jul 29, 2019 at 4:10 AM vignesh C <vignesh21@gmail.com> wrote:
I could not locate the caller of ParsePrepareRecord function in twophase.c.
Any idea how it gets called?
or
Is it a dead function?It looks like it's not only dead, but stillborn. Commit
1eb6d6527aae264b3e0b9c95aa70bb7a594ad1cf introduced it but without
introducing any code that called it, and nothing has changed since
then.
I feel the code can be safely removed.
Patch for the same is attached.
Regards,
Vignesh
EnterpriseDB: http://www.enterprisedb.com
On 2019-Jul-29, vignesh C wrote:
On Mon, Jul 29, 2019 at 8:24 PM Robert Haas <robertmhaas@gmail.com> wrote:
On Mon, Jul 29, 2019 at 4:10 AM vignesh C <vignesh21@gmail.com> wrote:
I could not locate the caller of ParsePrepareRecord function in twophase.c.
Any idea how it gets called?
or
Is it a dead function?It looks like it's not only dead, but stillborn. Commit
1eb6d6527aae264b3e0b9c95aa70bb7a594ad1cf introduced it but without
introducing any code that called it, and nothing has changed since
then.I feel the code can be safely removed.
Patch for the same is attached.
I think there's a patch from Fujii Masao that touches that? Might be
premature to remove it.
--
�lvaro Herrera https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
On Tue, Jul 30, 2019 at 2:34 AM Alvaro Herrera <alvherre@2ndquadrant.com> wrote:
On 2019-Jul-29, vignesh C wrote:
On Mon, Jul 29, 2019 at 8:24 PM Robert Haas <robertmhaas@gmail.com> wrote:
On Mon, Jul 29, 2019 at 4:10 AM vignesh C <vignesh21@gmail.com> wrote:
I could not locate the caller of ParsePrepareRecord function in twophase.c.
Any idea how it gets called?
or
Is it a dead function?It looks like it's not only dead, but stillborn. Commit
1eb6d6527aae264b3e0b9c95aa70bb7a594ad1cf introduced it but without
introducing any code that called it, and nothing has changed since
then.I feel the code can be safely removed.
Patch for the same is attached.I think there's a patch from Fujii Masao that touches that? Might be
premature to remove it.
Okay, can you point to that patch? Recently, Robert/Thomas has raised
a comment on undo machinery wherein we are considering to store
FullTransactionId in two-phase file. So, in that connection, we need
to modify this function as well. It is not impossible to test some
unused function (we can try it by superficially calling it at
someplace in code for the purpose of test), but it would have been
better if it is used in someplace.
[1]: /messages/by-id/CA+Tgmob1Oby7Wc5ryB_VBccU9N+uSKjXXocgT9dY_edfxqSA8Q@mail.gmail.com -- With Regards, Amit Kapila. EnterpriseDB: http://www.enterprisedb.com
--
With Regards,
Amit Kapila.
EnterpriseDB: http://www.enterprisedb.com
On 2019-Jul-30, Amit Kapila wrote:
On Tue, Jul 30, 2019 at 2:34 AM Alvaro Herrera <alvherre@2ndquadrant.com> wrote:
I think there's a patch from Fujii Masao that touches that? Might be
premature to remove it.Okay, can you point to that patch?
/messages/by-id/CAHGQGwFQgRWMOoRfbOOHXy1VdGM-YkwdwvWr_bD0TQXFTjD9Tw@mail.gmail.com
--
�lvaro Herrera https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
On Tue, Jul 30, 2019 at 08:42:06AM +0530, Amit Kapila wrote:
Okay, can you point to that patch?
Here you go:
https://commitfest.postgresql.org/23/2105/
The thread is mostly waiting after Fujii-san for an update.
--
Michael
On Tue, Jul 30, 2019 at 2:34 AM Alvaro Herrera <alvherre@2ndquadrant.com> wrote:
On 2019-Jul-29, vignesh C wrote:
On Mon, Jul 29, 2019 at 8:24 PM Robert Haas <robertmhaas@gmail.com> wrote:
On Mon, Jul 29, 2019 at 4:10 AM vignesh C <vignesh21@gmail.com> wrote:
I could not locate the caller of ParsePrepareRecord function in twophase.c.
Any idea how it gets called?
or
Is it a dead function?It looks like it's not only dead, but stillborn. Commit
1eb6d6527aae264b3e0b9c95aa70bb7a594ad1cf introduced it but without
introducing any code that called it, and nothing has changed since
then.I feel the code can be safely removed.
Patch for the same is attached.I think there's a patch from Fujii Masao that touches that? Might be
premature to remove it.
Ok, it makes sense not to remove it when there is some work being done in
different thread.
Regards,
Vignesh
EnterpriseDB: http://www.enterprisedb.com