Fix typos and inconsistencies for HEAD (take 9)
Hello hackers,
Please consider fixing the next truss of typos and inconsistencies in
the tree:
9.1. NAMESPACE_SQLXML -> remove (not used since the introduction in
355e05ab)
9.2. NBXLOG_H -> NBTXLOG_H
9.3. NEWPAGE -> XLOG_FPI (orphaned since 54685338)
9.4. newXlogId, newXlogSeg -> newXlogSegNo (orphaned since dfda6eba)
9.5. nextblno -> nextblkno
9.6. noCatalogs -> arg
9.7. nodeWindowFunc.c -> nodeWindowAgg.c
9.8. NOINHERITS -> NOINHERIT
9.9. NO_RESPONSE -> PQPING_NO_RESPONSE
9.10. Normalizationdata.txt- > NormalizationTest.txt
9.11. NOT_AVAIL -> LOCKACQUIRE_NOT_AVAIL
9.12. not_point -> is_point (a contradiction with the check and a
comment, appeared in 4c1383ef)
9.13. nptrs, ptrs -> nipd, ipd
9.14. nbuffers, nrdatas -> max_block_id, ndatas
9.15. nrow -> nrows
9.16. nsubxcnt -> subxcnt
9.17. ntzones, zp -> zonecount, zpfirst
9.18. nvmblocks -> vm_nblocks
9.19. objAddress -> objAddr
9.20. ObjectWithArg -> ObjectWithArgs
9.21. objOid, relOid -> objectId, classId, subId
9.22. ObjType -> ObjectType
9.23. OffsetNumberMask -> remove (not used since PG95-1_01)
9.24. oid_in_function -> remove (orphaned since 578b2297)
9.25. oidzero, oidge -> remove (not used since the introduction in 8dc42a3a)
9.26. oidle -> remove (orphaned since 9f0ae0c8)
9.27. oideq -> remove (orphaned since 005a1217)
9.28. OldestMemberMXactID -> OldestMemberMXactId
9.29. oldestXidDb -> oldestXactDb
9.30. oldest-Xmin -> oldestXmin
9.31. old_key_tup -> old_key_tuple
9.32. on_dsm_callback -> on_dsm_detach callback
9.33. ONE_PAGE -> TBM_ONE_PAGE
9.34. opt_boolean -> opt_boolean_or_string (renamed in 5c84fe46)
9.35. OptimizableStmt -> PreparableStmt (orphaned since aa83bc04)
9.36. optType -> remove (not used since the introduction in 500b62b0)
9.37. organizationUnitName -> organizationalUnitName (see
https://github.com/openssl/openssl/issues/1843)
9.38. origTupDesc -> origTupdesc
9.39. outputvariables -> output variables
9.40. ovflpgs -> ovflpages
9.41. OWNER_TO -> OWNER TO
9.42. PackedPostingList -> GinPostingList (an inconsistency since 36a35c55)
9.43. PageClearPrunable -> remove (not used since 6f10eb21)
9.44. pageLSN -> curPageLSN
9.45. paramListInfo -> ParamListInfo
9.46. PARSER_FUNC_H -> PARSE_FUNC_H
9.47. parse_hba -> parse_hba_line (renamed in 98723810)
9.48. parse_json -> pg_parse_json
9.49. pathkeys_contain_in -> pathkeys_contained_in
9.50. pattern1 -> pattern
9.51. patters -> patterns
9.52. PerAggData -> WindowStatePerAggData
9.53. PerFuncData -> WindowStatePerFuncData
9.54. pgaddtup -> this function
9.55. pg_atomic_test_and_set_flag -> pg_atomic_test_set_flag
9.56. pg_binary_read_file -> pg_read_binary_file
9.57. pgcommonfiles -> remove (orphaned since a7301839)
9.58. pgcontrolvalue, xlrecvalue -> oldvalue, newvalue
9.59. pg_dlsym -> dlsym (orphaned since 842cb9fa)
9.60. pg_encconv_tbl -> pg_enc2name_tbl (orphaned since eb335a03)
9.61. PGgetline -> PQgetline
9.62. pghackers -> pgsql-hackers
9.63. _pg_keysequal -> remove (not used since d26e1eba)
9.64. pg_language_metadata -> pg_largeobject_metadata
9.65. pgp_armor -> pg_armor
9.66. PGresTuple -> PGresult tuple
9.67. pgstat_recv_resetshared -> pgstat_recv_resetsharedcounter
9.68. pgtypes_date_months_short -> months (abbreviations)
9.69. PgXact -> MyPgXact
9.70. PlaceholderVars -> PlaceHolderVars
9.71. placeToPage -> beginPlaceToPage
9.72. PLpgSQL_dynfors -> PLpgSQL_stmt_dynfors
9.73. plpgsql_init -> _PG_init (orphaned since b09bfcaa)
9.74. PLy_munge_source -> PLy_procedure_munge_source
9.75. Point-in-Time -> Point-In-Time
9.76. PO_FILES, ALL_PO_FILES -> remove (orphaned since 4e1c7207, 5dd41f35)
9.77. pop_size -> pool_size
9.78. posid -> ip_posid, blkid -> ip_blkid
9.79. pq_close, pq_comm_reset -> socket_close, socket_comm_reset
(renamed in 2bd9e412)
9.80. pqcomprim.c -> pqformat.c (orphaned since 95cc41b)
9.81. PQescapeByte()a -> PQescapeBytea()
9.82. PQSetenv -> pqSetenv
9.83. PreCommit_CheckForSerializableConflicts ->
PreCommit_CheckForSerializationFailure
9.84. PREFER -> remove (not used since the introduction in 7bcc6d98)
9.85. prepared_transactions -> prepared-transactions
9.86. pressurel -> pressure
9.87. prettyprint -> pretty-print
9.88. PRETTY_SCHEMA -> remove (not used since the introduction in 3d2aed66)
9.89. printAttName, terseOutput, width -> PrintAttNames, TerseOutput,
colWidth
9.90. priorWALFileName -> remove (not used since the introduction in
51be14e9)
9.91. PROC_H -> _PROC_H_
9.92. ProcLWLockTranche -> remove (orphaned since 3761fe3c and
non-informational)
9.93. PUTBYTE -> remove (not used since the introduction in 0c0dde61)
9.94. px_hmac_block_size, px_hmac_reset -> remove (not used since the
introduction in df24cb73)
9.95. PX_MAX_NAMELEN -> remove (not used since 3cc86612)
Also, please fix my typo (from the previous set), that was somehow
silted through a double check.
Best regards,
Alexander
Attachments:
fix_for_fix_8.15.patchtext/x-patch; name=fix_for_fix_8.15.patchDownload+1-1
fixes_9.1-10.patchtext/x-patch; name=fixes_9.1-10.patchDownload+11-12
fixes_9.11-20.patchtext/x-patch; name=fixes_9.11-20.patchDownload+13-13
fixes_9.21-30.patchtext/x-patch; name=fixes_9.21-30.patchDownload+5-11
fixes_9.31-40.patchtext/x-patch; name=fixes_9.31-40.patchDownload+12-13
fixes_9.41-50.patchtext/x-patch; name=fixes_9.41-50.patchDownload+10-12
fixes_9.51-60.patchtext/x-patch; name=fixes_9.51-60.patchDownload+11-11
fixes_9.61-70.patchtext/x-patch; name=fixes_9.61-70.patchDownload+10-14
fixes_9.71-80.patchtext/x-patch; name=fixes_9.71-80.patchDownload+11-13
fixes_9.81-90.patchtext/x-patch; name=fixes_9.81-90.patchDownload+11-13
fixes_9.91-95.patchtext/x-patch; name=fixes_9.91-95.patchDownload+1-17
On Mon, Aug 05, 2019 at 12:33:34AM +0300, Alexander Lakhin wrote:
9.1. NAMESPACE_SQLXML -> remove (not used since the introduction in
355e05ab)
Looks important to keep as a matter of documentation.
9.12. not_point -> is_point (a contradiction with the check and a
comment, appeared in 4c1383ef)
That would mean a breakage for anybody relying on it, so I would not
change that.
9.17. ntzones, zp -> zonecount, zpfirst
Nope, this is upstream code.
9.41. OWNER_TO -> OWNER TO
This one needs a back-patch. I'll fix that separately.
9.43. PageClearPrunable -> remove (not used since 6f10eb21)
Better to keep it. Some extensions may rely on it, and it costs
nothing to keep around.
9.75. Point-in-Time -> Point-In-Time
Why? The original looks correct to me.
9.76. PO_FILES, ALL_PO_FILES -> remove (orphaned since 4e1c7207, 5dd41f35)
I am wondering if there are external things relying on that. So I
have let them.
9.88. PRETTY_SCHEMA -> remove (not used since the introduction in 3d2aed66)
This should be kept for consistent IMO. Even if not used yet, it
could be used for future patches.
9.94. px_hmac_block_size, px_hmac_reset -> remove (not used since the
introduction in df24cb73)
Hm. I think that it makes sense to keep them for consistency with the
other structures and callback reference lookups, and these macros may
prove to be useful for future patches.
Also, please fix my typo (from the previous set), that was somehow
silted through a double check.
Which one is that, please? It is likely possible that some obvious
stuff has been forgotten.
Committed a large bunch of this stuff. Please note that the
indentation was incorrect in a couple of places, including the change
in src/tools/msvc/.
--
Michael
Hello Michael,
05.08.2019 6:15, Michael Paquier wrote:
9.41. OWNER_TO -> OWNER TO
This one needs a back-patch. I'll fix that separately.
I believe that all the fixes in doc/ should be back-patched too. If it's
not too late, I can produce such patches for the nearest releases.
9.75. Point-in-Time -> Point-In-Time
Why? The original looks correct to me.
acronyms.sgml contains such spelling:
��� <term><acronym>PITR</acronym></term>
��� <listitem>
���� <para>
����� <link linkend="continuous-archiving">Point-In-Time
����� Recovery</link> (Continuous Archiving)
���� </para>
Also, please fix my typo (from the previous set), that was somehow
silted through a double check.Which one is that, please? It is likely possible that some obvious
stuff has been forgotten.
"It the username successfully retrieved,..." (fix_for_fix_8.15.patch)
Committed a large bunch of this stuff. Please note that the
indentation was incorrect in a couple of places, including the change
in src/tools/msvc/.
Thank you. I will check my Tab settings next time.
Best regards,
Alexander
Attachments:
fix_for_fix_8.15.patchtext/x-patch; name=fix_for_fix_8.15.patchDownload+1-1
On Mon, Aug 05, 2019 at 12:15:21PM +0900, Michael Paquier wrote:
On Mon, Aug 05, 2019 at 12:33:34AM +0300, Alexander Lakhin wrote:
9.41. OWNER_TO -> OWNER TO
This one needs a back-patch. I'll fix that separately.
Done separately as of 05ba837, and back-patched down to 9.6 as this
has been introduced by d37b816.
--
Michael
On Mon, Aug 05, 2019 at 06:44:46AM +0300, Alexander Lakhin wrote:
I believe that all the fixes in doc/ should be back-patched too. If it's
not too late, I can produce such patches for the nearest releases.
I think that's unfortunately a bit too late for this release. Those
things have been around for years, so three months to make them appear
on the website is not a big deal IMO. If you have something which
could be used as a base for back-branches with the most obvious typos,
that would be welcome (if you could group everything into a single
patch file, that would be even better...).
--
Michael
05.08.2019 8:40, Michael Paquier wrote:
On Mon, Aug 05, 2019 at 06:44:46AM +0300, Alexander Lakhin wrote:
I believe that all the fixes in doc/ should be back-patched too. If it's
not too late, I can produce such patches for the nearest releases.I think that's unfortunately a bit too late for this release. Those
things have been around for years, so three months to make them appear
on the website is not a big deal IMO. If you have something which
could be used as a base for back-branches with the most obvious typos,
that would be welcome (if you could group everything into a single
patch file, that would be even better...).
OK, I will make the desired patches for all the supported branches upon
reaching the end of my unique journey.
Best regards,
Alexander