Useless bms_free() calls in build_child_join_rel()
Started by Etsuro Fujitaover 6 years ago2 messages
Hi,
While working on the PWJ patch [1]/messages/by-id/CAPmGK16wDqJiUof8+e4HuGmrAqqoFzb=iQX4V+xicsJ5_BvJ=g@mail.gmail.com, I noticed $SUBJECT. They seem to
be leftovers from the original partitionwise-join patch, perhaps.
Attached is a patch for removing them.
Best regards,
Etsuro Fujita
[1]: /messages/by-id/CAPmGK16wDqJiUof8+e4HuGmrAqqoFzb=iQX4V+xicsJ5_BvJ=g@mail.gmail.com
Attachments:
remove-useless-bms_free-calls.patchapplication/octet-stream; name=remove-useless-bms_free-calls.patchDownload
diff --git a/src/backend/optimizer/util/relnode.c b/src/backend/optimizer/util/relnode.c
index 19e5a449f7..85415381fb 100644
--- a/src/backend/optimizer/util/relnode.c
+++ b/src/backend/optimizer/util/relnode.c
@@ -858,11 +858,8 @@ build_child_join_rel(PlannerInfo *root, RelOptInfo *outer_rel,
/*
* Lateral relids referred in child join will be same as that referred in
- * the parent relation. Throw any partial result computed while building
- * the targetlist.
+ * the parent relation.
*/
- bms_free(joinrel->direct_lateral_relids);
- bms_free(joinrel->lateral_relids);
joinrel->direct_lateral_relids = (Relids) bms_copy(parent_joinrel->direct_lateral_relids);
joinrel->lateral_relids = (Relids) bms_copy(parent_joinrel->lateral_relids);
Re: Useless bms_free() calls in build_child_join_rel()
On Thu, Aug 15, 2019 at 8:31 PM Etsuro Fujita <etsuro.fujita@gmail.com> wrote:
While working on the PWJ patch [1], I noticed $SUBJECT. They seem to
be leftovers from the original partitionwise-join patch, perhaps.
Attached is a patch for removing them.
Pushed.
Best regards,
Etsuro Fujita