Sep 2022

3 commits
Improve ICU option handling in CREATE DATABASE
21 Sep 2022Peter Eisentrautmaster16beta1REL_19_STABLE16beta1REL_18_STABLE16beta1REL_17_STABLE16beta1REL_16_STABLE16beta1REL_15_STABLE15rc1
LLM analysis, 100% suremodified before commitlight changesfrom patchset #1041 of 1 reviewer saw the final version

The dbcommands.c changes match #104; the commit additionally includes Marina's inline regression test from #105, as confirmed in #106.

  • Marina Polyakovasaw the final versionLLM analysis, 100% sureMarina confirmed that #104 worked and supplied the regression test incorporated into the commit in #105.
Don't allow creation of database with ICU locale with unsupported encoding
16 Sep 2022Peter Eisentrautmaster16beta1REL_19_STABLE16beta1REL_18_STABLE16beta1REL_17_STABLE16beta1REL_16_STABLE16beta1REL_15_STABLE15rc1
LLM analysis, 99% suremodified before commitmoderate changesfrom patchset #882 of 2 reviewers saw the final version

Peter explicitly selected the first patch #88 in #95, avoiding the broader initdb reordering in #90. The commit factors out an encoding-check helper, adjusts check placement and tests, and adds UTF8-default documentation and output.

  • Kyotaro Horiguchisaw the final versiontrailerKyotaro reviewed the source patch in #89, requested earlier encoding checks, and tested and discussed explicit non-UTF8 encodings in #92.
  • Peter Eisentrautsaw the final versioncommittercommitted the patch
Make locale option behavior more consistent
13 Sep 2022Peter Eisentrautmaster16beta1REL_19_STABLE16beta1REL_18_STABLE16beta1REL_17_STABLE16beta1REL_16_STABLE16beta1REL_15_STABLE15rc1
LLM analysis, 100% surewritten from the discussion, no matching patch1 of 2 reviewers saw the final version

The attachment #83 restores a backend restriction, whereas this commit relaxes createdb's restriction using Marina's inline patch in #85, following Justin's alternative in #84. It also updates CREATE DATABASE documentation.

  • Justin Pryzbysaw an earlier versiontrailerJustin reviewed #83 and proposed relaxing createdb instead in #84, but did not review the thread's final patchset #110.
  • Peter Eisentrautsaw the final versioncommittercommitted the patch

Aug 2022

4 commits
pg_dump: Dump colliculocale
24 Aug 2022Peter Eisentrautmaster16beta1REL_19_STABLE16beta1REL_18_STABLE16beta1REL_17_STABLE16beta1REL_16_STABLE16beta1REL_15_STABLE15beta4
LLM analysis, 100% suremodified before commitlight changesfrom patchset #782 of 2 reviewers saw the final version

The pg_dump.c implementation and Makefile change match #78. Committer edits rename the test's ICU marker and cache ICU availability in a supports_icu variable.

  • Julien Rouhaudsaw the final versiontrailerJulien explicitly said the patch looked good in #80, after reviewing #78.
  • Peter Eisentrautsaw the final versioncommittercommitted the patch
Fix ICU locale option handling in CREATE DATABASE
24 Aug 2022Peter Eisentrautmaster16beta1REL_19_STABLE16beta1REL_18_STABLE16beta1REL_17_STABLE16beta1REL_16_STABLE16beta1REL_15_STABLE15beta4
LLM analysis, 100% surewritten from the discussion, no matching patch0 of 2 reviewers saw the final version

This deletes the five-line LOCALE-to-ICU_LOCALE fallback in dbcommands.c, implementing Peter's conclusion in #75 about the inconsistency reported in #72. No attachment proposes this deletion.

  • Marina Polyakovasaw an earlier versionLLM analysis, 99% sureMarina demonstrated the inconsistent ICU-locale fallback in #72, prompting this discussion-derived fix before the final submission #110.
  • Julien Rouhaudsaw an earlier versionLLM analysis, 88% sureJulien examined the createdb/CREATE DATABASE discrepancy in #73, initially favoring extending the fallback rather than deleting it, before the final submission #110.
Fix assertion failure in CREATE DATABASE
22 Aug 2022Peter Eisentrautmaster16beta1REL_19_STABLE16beta1REL_18_STABLE16beta1REL_17_STABLE16beta1REL_16_STABLE16beta1REL_15_STABLE15beta4
LLM analysis, 100% surewritten from the discussion, no matching patch0 of 1 reviewer saw the final version

The dbcommands.c fix matches Marina's inline revision in #74, incorporating Julien's initialization-order suggestion in #73, and adds a regression test. The attachment in #74 only contains diagnostic logging.

  • Julien Rouhaudsaw an earlier versiontrailerJulien proposed inheriting the ICU locale only after determining the provider in #73, with no review of the final patchset #110.
pg_upgrade: Fix thinko in database info acquisition routine
22 Aug 2022Peter Eisentrautmaster16beta1REL_19_STABLE16beta1REL_18_STABLE16beta1REL_17_STABLE16beta1REL_16_STABLE16beta1REL_15_STABLE15beta4
LLM analysis, 100% surewritten from the discussion, no matching patch0 of 1 reviewer saw the final version

The single-line pg_upgrade/info.c change exactly implements the inline patch in #72, checking cluster->major_version instead of old_cluster.major_version.

  • Julien Rouhaudsaw an earlier versiontrailerJulien endorsed the pg_upgrade bug finding in #73, but did not review the final patchset #110.

Jun 2022

1 commit
pg_upgrade: Fix version comparison for global ICU support
27 Jun 2022Peter Eisentrautmaster15beta2REL_19_STABLE15beta2REL_18_STABLE15beta2REL_17_STABLE15beta2REL_16_STABLE15beta2REL_15_STABLE15beta2
LLM analysis, 100% surewritten from the discussion, no matching patch0 of 3 reviewers saw the final version

Justin reported the incorrect PostgreSQL 15 version boundary in #65; Peter proposed changing <= to < in #68 and confirmed committing that exact pg_upgrade/info.c correction in #70.

  • Justin Pryzbysaw an earlier versionLLM analysis, 97% sureJustin identified the incorrect version boundary and proposed an equivalent correction in #65, before the final patchset #110.
  • Julien Rouhaudsaw an earlier versionLLM analysis, 94% sureJulien confirmed Justin's version-boundary finding in #66, before the final patchset #110.
  • Michael Paquiersaw an earlier versionLLM analysis, 99% sureMichael explained the upgrade consequences in #67 and approved Peter's exact comparison correction in #69, before the final patchset #110.

Mar 2022

3 commits
Silence -Wmaybe-uninitialized compiler warning in dbcommands.c.
19 Mar 2022Andres Freundmaster15beta1REL_19_STABLE15beta1REL_18_STABLE15beta1REL_17_STABLE15beta1REL_16_STABLE15beta1REL_15_STABLE15beta1
LLM analysis, 100% surewritten from the discussion, no matching patch

Andres reported the -O3 compiler warning and announced initializing src_locprovider in #64; the commit makes that one-line dbcommands.c change without an attached patch.

Add option to use ICU as global locale provider
17 Mar 2022Peter Eisentrautmaster15beta1REL_19_STABLE15beta1REL_18_STABLE15beta1REL_17_STABLE15beta1REL_16_STABLE15beta1REL_15_STABLE15beta1
LLM analysis, 100% suremodified before commitmoderate changesfrom patchset #491 of 1 reviewer saw the final version

The implementation follows #49, with added localization documentation, a catalog-version bump, and explicit unexpected-null errors in collation/database version functions. Those final changes address #51 and are confirmed in #58.

  • Julien Rouhaudsaw the final versiontrailerJulien reviewed the revived design, tested ICU sorting in #46, and reviewed the final submitted patch with the null-handling corrections adopted from #51.
DefineCollation() code cleanup
11 Mar 2022Peter Eisentrautmaster15beta1REL_19_STABLE15beta1REL_18_STABLE15beta1REL_17_STABLE15beta1REL_16_STABLE15beta1REL_15_STABLE15beta1
LLM analysis, 100% surelanded as postedfrom patchset #471 of 1 reviewer saw the final version

The DefineCollation() changes in src/backend/commands/collationcmds.c match #47 without substantive edits.

  • Julien Rouhaudsaw the final versiontrailerJulien requested the cleanup in #46 and explicitly endorsed its implementation in #48.

Jan 2022

2 commits
Change collate and ctype fields to type text
27 Jan 2022Peter Eisentrautmaster15beta1REL_19_STABLE15beta1REL_18_STABLE15beta1REL_17_STABLE15beta1REL_16_STABLE15beta1REL_15_STABLE15beta1
LLM analysis, 100% suremodified before commitlight changesfrom patchset #391 of 1 reviewer saw the final version

The catalog-field conversion matches #39; the additional change is the required src/include/catalog/catversion.h bump.

  • Julien Rouhaudsaw the final versiontrailerJulien reported passing tests and documentation builds in #40 and accepted the explanation of datum-decoding placement in #42.
Call pg_newlocale_from_collation() also with default collation
20 Jan 2022Peter Eisentrautmaster15beta1REL_19_STABLE15beta1REL_18_STABLE15beta1REL_17_STABLE15beta1REL_16_STABLE15beta1REL_15_STABLE15beta1
LLM analysis, 100% surelanded as postedfrom patchset #331 of 1 reviewer saw the final version

The changes across the eight backend files match #33, consistently passing the default collation through pg_newlocale_from_collation().

  • Julien Rouhaudsaw the final versiontrailerJulien investigated the historical performance concern, ran benchmarks in #22, and reported that #33 looked good and passed regression tests in #37.

Credits across 13 commits

Author
Peter EisentrautLLM5
Marina Polyakova3
Reviewer
Julien Rouhaud7
Peter Eisentrautcommitter3
Justin Pryzby1
Kyotaro Horiguchi1
Reported by
Marina Polyakova4
Justin Pryzby1
Committer
Peter Eisentraut12
Andres Freund1

N LLM means N of the credits come from LLM analysis, not from commit trailers.