model-writtenrun 9175 - may be wrong, links go to the source messages. Commit-by-commit LLM analysis is in the Commits dialog.
- Peter Eisentraut proposed making pg_upgrade reject unexpected positional arguments, matching other PostgreSQL utilities #1.
- Tom Lane asked whether other utilities lacked the check #3, Julien Rouhaud identified oid2name #4, and Ibrar Ahmed supplied its separate fix #5.
- Michael Paquier identified pgbench as another affected utility #6, and Ibrar Ahmed supplied a check allowing its optional database-name argument #7.
- Peter Eisentraut combined all three fixes in 9684e42695, adjusting diagnostics and making pgbench consume the database name before checking for excess arguments, then announced the push #8.
- After the commit, Fabien COELHO proposed a one-line pgbench TAP test #9; following Michael Paquier's suggestion to broaden testing #10, Fabien explained that pg_upgrade lacked suitable TAP infrastructure and oid2name had only basic checks #11.
- Tom Lane questioned whether this regression test justified its continuing execution cost #12, while Fabien COELHO defended its coverage benefit and reported negligible added runtime #13; Tom maintained that the likely benefit was too small #14.
- The functional fixes were committed, but the additional TAP test remained uncommitted in the supplied record; Fabien COELHO closed by defending separate classes of tests and the suitability of pgbench-specific TAP coverage #15.