Apr 2021

1 commit
Add sortsupport for gist_btree opclasses, for faster index builds.
7 Apr 2021Heikki Linnakangasmaster14beta1REL_19_STABLE14beta1REL_18_STABLE14beta1REL_17_STABLE14beta1REL_16_STABLE14beta1REL_15_STABLE14beta1REL_14_STABLE14beta1
LLM analysis, 100% suremodified before commitmoderate changesfrom patchset #1261 of 2 reviewers saw the final version

The btree_gist implementation matches #126 with typed Datum conversions, signed abbreviated comparisons, and a corrected macaddr shift, as described in #128. The closer match in #134 is a later reattachment of the committed version.

  • Justin Pryzbysaw an earlier versionLLM analysis, 98% sureProposed DEBUG1 regression checks in #98, adopted in #99, before subsequent comparator and abbreviation corrections.
  • Heikki Linnakangassaw the final versioncommittercommitted the patch

Jan 2021

4 commits
pageinspect: Fix relcache leak in gist_page_items().
17 Jan 2021Heikki Linnakangasmaster14beta1REL_19_STABLE14beta1REL_18_STABLE14beta1REL_17_STABLE14beta1REL_16_STABLE14beta1REL_15_STABLE14beta1REL_14_STABLE14beta1
LLM analysis, 100% surewritten from the discussion, no matching patch1 of 1 reviewer saw the final version

Tom Lane identified the unsafe cross-call relation lifetime in #117; the commit rewrites both item functions in contrib/pageinspect/gistfuncs.c to materialize tuplestores, confirmed in #119, without an attached fix patch.

  • Tom Lanesaw the final versionLLM analysis, 100% sureIdentified the relcache leak and proposed tuplestore materialization in #117, which the committer implemented in #119.
Fix test failure with wal_level=minimal.
13 Jan 2021Heikki Linnakangasmaster14beta1REL_19_STABLE14beta1REL_18_STABLE14beta1REL_17_STABLE14beta1REL_16_STABLE14beta1REL_15_STABLE14beta1REL_14_STABLE14beta1
LLM analysis, 100% surewritten from the discussion, no matching patch1 of 1 reviewer saw the final version

The thorntail failure discussed in #109 was reproduced with wal_level=minimal in #112. The commit wraps index creation and page-LSN checks in one transaction in contrib/pageinspect/sql/gist.sql and its expected output; no attached patch supplies this fix.

  • Tom Lanesaw the final versionLLM analysis, 91% sureReported the remaining thorntail test failure before the fix in #110.
Fix portability issues in the new gist pageinspect test.
13 Jan 2021Heikki Linnakangasmaster14beta1REL_19_STABLE14beta1REL_18_STABLE14beta1REL_17_STABLE14beta1REL_16_STABLE14beta1REL_15_STABLE14beta1REL_14_STABLE14beta1
LLM analysis, 100% surewritten from the discussion, no matching patch1 of 1 reviewer saw the final version

Implements Andrey Borodin's proposal in #107 to omit platform-dependent key_data and removes non-leftmost-leaf expectations sensitive to 32-bit page capacity. Heikki confirms the fix in #108; no attached fix patch exists.

  • Andrey Borodinsaw the final versionLLM analysis, 100% sureQuestioned test portability in #105 and proposed omitting key_data in #107, which was adopted.
Add functions to 'pageinspect' to inspect GiST indexes.
13 Jan 2021Heikki Linnakangasmaster14beta1REL_19_STABLE14beta1REL_18_STABLE14beta1REL_17_STABLE14beta1REL_16_STABLE14beta1REL_15_STABLE14beta1REL_14_STABLE14beta1
LLM analysis, 100% suremodified before commitlight changesfrom patchset #1041 of 2 reviewers saw the final version

The C implementation and SQL interfaces match #104; committer edits change regression-output formatting and remove two redundant error tests. The commit credits Andrey Borodin and Heikki Linnakangas jointly, with Andrey's contribution visible in #100 and #103.

  • Peter Geoghegansaw an earlier versionLLM analysis, 99% sureRecommended BuildIndexValueDescription() in #101, adopted in #103 before the relation-aware API was further revised.
  • Heikki Linnakangassaw the final versioncommittercommitted the patch

Oct 2020

1 commit
Fix missing validation for the new GiST sortsupport functions.
30 Oct 2020Heikki Linnakangasmaster14beta1REL_19_STABLE14beta1REL_18_STABLE14beta1REL_17_STABLE14beta1REL_16_STABLE14beta1REL_15_STABLE14beta1REL_14_STABLE14beta1
LLM analysis, 100% surepart of a posted patchsetsignificant changesfrom patchset #921 of 1 reviewer saw the final version

Extracts only the GIST_SORTSUPPORT_PROC case in gistadjustmembers() from #92, leaving its btree_gist feature uncommitted. The same hunk appears in #90, while #95 was sent after this commit.

  • Heikki Linnakangassaw the final versioncommittercommitted the patch

Sep - Oct 2020

3 commits
Set right-links during sorted GiST index build.
1 Oct 2020Heikki Linnakangasmaster14beta1REL_19_STABLE14beta1REL_18_STABLE14beta1REL_17_STABLE14beta1REL_16_STABLE14beta1REL_15_STABLE14beta1REL_14_STABLE14beta1
LLM analysis, 100% suremodified before commitlight changesfrom patchset #841 of 1 reviewer saw the final version

Preserves the one-line rightlink assignment from #84 and adds the explanatory comment proposed inline by Heikki Linnakangas in #85.

  • Heikki Linnakangassaw the final versioncommittercommitted the patch
Fix checksum calculation in the new sorting GiST build.
21 Sep 2020Heikki Linnakangasmaster14beta1REL_19_STABLE14beta1REL_18_STABLE14beta1REL_17_STABLE14beta1REL_16_STABLE14beta1REL_15_STABLE14beta1REL_14_STABLE14beta1
LLM analysis, 100% surewritten from the discussion, no matching patch2 of 2 reviewers saw the final version

Implements the checksum failure and inline repair reported in #72, adding PageSetChecksumInplace() and defensive RelationOpenSmgr() calls in gistbuild.c. The additional calls follow #73 and are explained in #77.

  • Justin Pryzbysaw the final versionLLM analysis, 98% sureSupplied a reproducer and inline checksum-fix sketch in #72, which the committer adapted.
  • Tom Lanesaw the final versionLLM analysis, 100% sureIdentified the missing storage-manager and checksum setup around direct writes in #73, leading to the defensive calls explained in #77.
Add support for building GiST index by sorting.
17 Sep 2020Heikki Linnakangasmaster14beta1REL_19_STABLE14beta1REL_18_STABLE14beta1REL_17_STABLE14beta1REL_16_STABLE14beta1REL_15_STABLE14beta1REL_14_STABLE14beta1
LLM analysis, 100% suremodified before commitlight changesfrom patchset #611 of 3 reviewers saw the final version

Matches the implementation and tests in #61, with only a small documentation wording change in doc/src/sgml/gist.sgml. Although Heikki sent the final patch, its Author credit and the original submission #1 identify Andrey Borodin.

  • Pavel Borisovsaw an earlier versiontrailerBenchmarked and reviewed the earlier series in #32 and #36 and endorsed the negative-coordinate fix in #44, before direct-write restructuring and abbreviated-key changes.
  • Thomas Munrosaw an earlier versiontrailerFound portability, documentation, NaN-placement, and patch-organization issues in #15, #28, and #30, before the builder was substantially reworked.
  • Heikki Linnakangassaw the final versioncommittercommitted the patch

Credits across 9 commits

Author
Andrey Borodin5
me1
Reviewer
Heikki Linnakangascommitter5
Pavel Borisov1
Thomas Munro1
Reported by
Tom Lane1
Committer
Heikki Linnakangas9