Improve base backup protocol documentation
It was apparently entirely undocumented that the tablespace size
estimates sent by the base backup protocol are in kilobytes. Here is a
patch to document that. Also, a related clarification in the
pg_basebackup.c source code: It was not clear without analyzing the
whole stack that "totalsize" is in kilobytes and "totaldone" is in bytes.
--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
Attachments:
0001-Improve-base-backup-protocol-documentation.patchtext/plain; charset=UTF-8; name=0001-Improve-base-backup-protocol-documentation.patch; x-mac-creator=0; x-mac-type=0Download+9-10
On Wed, Aug 28, 2019 at 4:58 PM Peter Eisentraut <
peter.eisentraut@2ndquadrant.com> wrote:
It was apparently entirely undocumented that the tablespace size
estimates sent by the base backup protocol are in kilobytes. Here is a
patch to document that. Also, a related clarification in the
pg_basebackup.c source code: It was not clear without analyzing the
whole stack that "totalsize" is in kilobytes and "totaldone" is in bytes.
+1, these both look like reasonable changes to me.
//Magnus
On 2019-09-03 09:50, Magnus Hagander wrote:
On Wed, Aug 28, 2019 at 4:58 PM Peter Eisentraut
<peter.eisentraut@2ndquadrant.com
<mailto:peter.eisentraut@2ndquadrant.com>> wrote:It was apparently entirely undocumented that the tablespace size
estimates sent by the base backup protocol are in kilobytes. Here is a
patch to document that. Also, a related clarification in the
pg_basebackup.c source code: It was not clear without analyzing the
whole stack that "totalsize" is in kilobytes and "totaldone" is in
bytes.+1, these both look like reasonable changes to me.
committed
--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services