[PATCH] psql: add tab completion for \df slash command suffixes

Started by Ian Lawrence Barwickover 6 years ago4 messageshackers
Jump to latest
#1Ian Lawrence Barwick
barwick@gmail.com

Hi

I just noticed "\df[TAB]" fails to offer any tab-completion for
the possible suffixes ("\dfa", "\dfn", "\dfp", "\dft" and "\dfw").
Trivial patch attached, which applies back to Pg96, and separate
patches for Pg95 and Pg94.

I'll add this to the next commitfest.

Regards

Ian Barwick

--
Ian Barwick https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services

Attachments:

psql-df-tab-completion.v1.patchtext/x-patch; name=psql-df-tab-completion.v1.patchDownload+2-1
psql-df-tab-completion-pg94.v1.patchtext/x-patch; name=psql-df-tab-completion-pg94.v1.patchDownload+2-1
psql-df-tab-completion-pg95.v1.patchtext/x-patch; name=psql-df-tab-completion-pg95.v1.patchDownload+2-1
#2Kuntal Ghosh
kuntalghosh.2007@gmail.com
In reply to: Ian Lawrence Barwick (#1)
Re: [PATCH] psql: add tab completion for \df slash command suffixes

Hello Ian,

On Fri, Aug 30, 2019 at 10:31 AM Ian Barwick
<ian.barwick@2ndquadrant.com> wrote:

I just noticed "\df[TAB]" fails to offer any tab-completion for
the possible suffixes ("\dfa", "\dfn", "\dfp", "\dft" and "\dfw").
Trivial patch attached, which applies back to Pg96, and separate
patches for Pg95 and Pg94.

I'll add this to the next commitfest.

I've reviewed the patch. It works as expected in master. But, the
syntax "\dfp" doesn't exist beyond Pg11. So, you've to remove the same
from the patches for Pg95 and Pg94. I guess the same patch should be
applied on Pg10 and Pg96.

--
Thanks & Regards,
Kuntal Ghosh
EnterpriseDB: http://www.enterprisedb.com

#3Ian Lawrence Barwick
barwick@gmail.com
In reply to: Kuntal Ghosh (#2)
Re: [PATCH] psql: add tab completion for \df slash command suffixes

On 2019/09/04 15:14, Kuntal Ghosh wrote:

Hello Ian,

On Fri, Aug 30, 2019 at 10:31 AM Ian Barwick
<ian.barwick@2ndquadrant.com> wrote:

I just noticed "\df[TAB]" fails to offer any tab-completion for
the possible suffixes ("\dfa", "\dfn", "\dfp", "\dft" and "\dfw").
Trivial patch attached, which applies back to Pg96, and separate
patches for Pg95 and Pg94.

I'll add this to the next commitfest.

I've reviewed the patch. It works as expected in master. But, the
syntax "\dfp" doesn't exist beyond Pg11. So, you've to remove the same
from the patches for Pg95 and Pg94. I guess the same patch should be
applied on Pg10 and Pg96.

Ah, good catch, I will update and resubmit.

Thanks!

Ian Barwick

--
Ian Barwick https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services

#4Michael Paquier
michael@paquier.xyz
In reply to: Ian Lawrence Barwick (#3)
Re: [PATCH] psql: add tab completion for \df slash command suffixes

On Wed, Sep 04, 2019 at 03:19:57PM +0900, Ian Barwick wrote:

Ah, good catch, I will update and resubmit.

Ping. Ian, could you update and resubmit please?
--
Michael