pg_dump --exclude-* options documentation

We have the following options in pg_dump:

--exclude-schema=schema
--exclude-table=table
--exclude-table-data=table

and new in pg_dumpall:

--exclude-database=pattern

I was momentarily confused that the latter is documented as taking a
"pattern" but the others are not. Of course they all take the same kind
of pattern.

Should we change the documentation of the old pg_dump options to also
take a "pattern", or change the documentation of the new pg_dumpall
option to read "database"?

My 0.02€: we should use the more general and precise, i.e. pattern.

--
Fabien.

Fabien COELHO <coelho@cri.ensmp.fr> writes:

Should we change the documentation of the old pg_dump options to also
take a "pattern", or change the documentation of the new pg_dumpall
option to read "database"?

My 0.02€: we should use the more general and precise, i.e. pattern.

+1 ... it doesn't seem to me that "--exclude-schema=schema" conveys
anything useful.

regards, tom lane

On 2019-09-02 16:55, Tom Lane wrote:

Fabien COELHO <coelho@cri.ensmp.fr> writes:

Should we change the documentation of the old pg_dump options to also
take a "pattern", or change the documentation of the new pg_dumpall
option to read "database"?

My 0.02€: we should use the more general and precise, i.e. pattern.

+1 ... it doesn't seem to me that "--exclude-schema=schema" conveys
anything useful.

done

--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services