msys2 vs pg_upgrade/test.sh
Diagnosing this took quite a lot of time and detective work. For some
reason I don't quite understand, when calling the Windows command
processor in a modern msys2/WindowsServer2019 installation, you need to
double the slash, thus:
cmd //c foo.bat
Some Internet postings at least seem to suggest this is by design. (FSVO
"design")
I tested this on older versions and the change appears to work, so I
propose to apply the attached patch.
This is the last obstacle I have to declaring msys2 fully supportable.
cheers
andrew
--
Andrew Dunstan https://www.2ndQuadrant.com
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
Attachments:
pg_upgrade_msys2.patchtext/x-patch; name=pg_upgrade_msys2.patchDownload+5-2
On 2019-09-09 00:06, Andrew Dunstan wrote:
Diagnosing this took quite a lot of time and detective work. For some
reason I don't quite understand, when calling the Windows command
processor in a modern msys2/WindowsServer2019 installation, you need to
double the slash, thus:cmd //c foo.bat
Some Internet postings at least seem to suggest this is by design. (FSVO
"design")I tested this on older versions and the change appears to work, so I
propose to apply the attached patch.
If we're worried about messing things up for non-msys2 environments, we
could also set MSYS2_ARG_CONV_EXCL instead; see
<https://github.com/msys2/msys2/wiki/Porting#filesystem-namespaces>.
According to that page, that would seem to be the more proper way to do it.
--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
On 9/9/19 4:48 AM, Peter Eisentraut wrote:
On 2019-09-09 00:06, Andrew Dunstan wrote:
Diagnosing this took quite a lot of time and detective work. For some
reason I don't quite understand, when calling the Windows command
processor in a modern msys2/WindowsServer2019 installation, you need to
double the slash, thus:cmd //c foo.bat
Some Internet postings at least seem to suggest this is by design. (FSVO
"design")I tested this on older versions and the change appears to work, so I
propose to apply the attached patch.If we're worried about messing things up for non-msys2 environments, we
could also set MSYS2_ARG_CONV_EXCL instead; see
<https://github.com/msys2/msys2/wiki/Porting#filesystem-namespaces>.
According to that page, that would seem to be the more proper way to do it.
Nice find, thanks, I'll do it that way.
cheers
andrew
--
Andrew Dunstan https://www.2ndQuadrant.com
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services