model-writtenrun 9136 - may be wrong, links go to the source messages. Commit-by-commit LLM analysis is in the Commits dialog.
- Tom Lane opened the thread by identifying that nondeterministic equality could disagree with the other text_pattern_ops and bpchar_pattern_ops operations, while introducing separate equality operators would prevent existing equality queries from using those indexes #1.
- Peter Eisentraut pointed out that runtime comparison checks already reject the problematic indexes #2; Tom argued that these checks were expensive, produced misleading errors, and unnecessarily rejected valid sorts, proposing rejection during index creation instead and leaving hash operator classes unchanged #3.
- Peter submitted the patch implementing that approach, noting that assigning operator-class OIDs would require a catalog-version bump and that the relocated comment still needed rewriting #4.
- Tom reviewed the patch, requested checking operator-class identity before the collation lookup, supplied a replacement comment, and discussed the extra lookup cost of avoiding a catalog-version bump #5.
- With the release candidate approaching, Tom committed Peter's patch as 2810396312, incorporating the review changes, restricting the validation loop to index key attributes, and adding the catalog-version bump; the fix was also backpatched to PostgreSQL 12, and Tom announced the landing after closer review #7.
- Peter confirmed that the landing covered all remaining open issues, closing the thread with the proposed fix committed #8.