Sep - Oct 2019

5 commits
Make crash recovery ignore recovery_min_apply_delay setting.
18 Oct 2019Fujii Masaomaster13beta1REL_19_STABLE13beta1REL_18_STABLE13beta1REL_17_STABLE13beta1REL_16_STABLE13beta1REL_15_STABLE13beta1REL_14_STABLE13beta1REL_13_STABLE13beta1+1 moreAlso in: recovery_min_apply_delay in archive recovery causes assertion failure in latch (part of a posted patchset)
Make crash recovery ignore restore_command and recovery_end_command settings.
11 Oct 2019Fujii Masaomaster13beta1REL_19_STABLE13beta1REL_18_STABLE13beta1REL_17_STABLE13beta1REL_16_STABLE13beta1REL_15_STABLE13beta1REL_14_STABLE13beta1REL_13_STABLE13beta1+1 more
LLM analysis, 100% surelanded as postedfrom patchset #191 of 1 reviewer saw the final version

Both changes match #19: StartupXLOG() restricts recovery_end_command to ArchiveRecoveryRequested, and RestoreArchivedFile() bypasses restore_command otherwise. The changed lines match exactly, with only rebased context.

  • Peter Eisentrautsaw the final versiontrailerPeter reviews the patch in #33, approves its correctness, and checks whether archive_cleanup_command and recoveryApplyDelay() need analogous handling.
Make crash recovery ignore recovery target settings.
30 Sep 2019Fujii Masaomaster13beta1REL_19_STABLE13beta1REL_18_STABLE13beta1REL_17_STABLE13beta1REL_16_STABLE13beta1REL_15_STABLE13beta1REL_14_STABLE13beta1REL_13_STABLE13beta1+1 more
LLM analysis, 100% surelanded as postedfrom patchset #161 of 1 reviewer saw the final version

The two ArchiveRecoveryRequested guards in xlog.c exactly match #16. The commit credits Peter Eisentraut, who supplied the inline implementation in #15, subsequently corrected and tested by Fujii Masao.

  • Fujii Masaosaw the final versiontrailerFujii corrects the guard to handle backup_label without a signal file and reports successful reproduction testing in #16, then commits the patch as announced in #19.
doc: Further clarify how recovery target parameters are applied
29 Sep 2019Peter Eisentrautmaster13beta1REL_19_STABLE13beta1REL_18_STABLE13beta1REL_17_STABLE13beta1REL_16_STABLE13beta1REL_15_STABLE13beta1REL_14_STABLE13beta1REL_13_STABLE13beta1+1 more
LLM analysis, 99% surewritten from the discussion, no matching patch

This rewrites config.sgml to acknowledge that all recovery targets apply in standby mode, resolving the behavior discussed in #2, #3, and #7. No attachment contains this rewrite; Peter announces the documentation correction in #17.

doc: Add timeline as valid recovery target in standby.signal documentation
27 Sep 2019Peter Eisentrautmaster13beta1REL_19_STABLE13beta1REL_18_STABLE13beta1REL_17_STABLE13beta1REL_16_STABLE13beta1REL_15_STABLE13beta1REL_14_STABLE13beta1REL_13_STABLE13beta1+1 more
LLM analysis, 100% surelanded as postedfrom patchset #12 of 2 reviewers saw the final version

The config.sgml hunk exactly matches David Steele's attachment in #1, adding the recovery_target_timeline exception. Peter confirms committing the original patch in #6.

  • Fujii Masaosaw the final versionLLM analysis, 86% sureFujii challenges the proposed documentation's remaining exclusion of other recovery targets in #2, identifying that they also take effect with standby.signal.
  • Peter Eisentrautsaw the final versioncommittercommitted the patch

Credits across 5 commits

Author
Fujii Masao2
David Steele1
Peter Eisentraut1
Reviewer
Peter Eisentrautcommitter2
Fujii Masao1
Michael Paquier1
Committer
Fujii Masao3
Peter Eisentraut2