model-writtenrun 9056 - may be wrong, links go to the source messages. Commit-by-commit LLM analysis is in the Commits dialog.
- Andrew Dunstan opened the thread by asking whether the longstanding prohibition on readline for MinGW could be lifted to provide readline-enabled psql on Windows #1.
- Victor Spirin posted a Windows tab-completion fix that reversed TailMatches arguments #2, then identified incorrect VA_ARGS_NARGS counting as the underlying problem #3; Tom Lane explained that the proposed reversal broke column completion after a table's WHERE clause #4.
- Victor replaced the completion-site change with an MSVC-specific EXPAND wrapper in src/include/c.h #6, and Michael Paquier requested an explanation of its behavior and a supporting code comment #7.
- Separately, Peter Eisentraut tested readline on Windows and encountered global-variable linking failures followed by unusable interactive behavior #8; Tom questioned terminal detection and the removed variable assignments #9, while Peter clarified that even line editing without tab completion would be useful #10.
- After roughly three years, Thomas Munro revived the macro fix because he wanted to use VA_ARGS_NARGS elsewhere, explained MSVC's treatment of __VA_ARGS__, and proposed retaining the workaround with documentation rather than dropping support for older compilers #11.
- Tom favored hiding the compatibility workaround inside the macro #12, and Michael agreed while observing that the MSVC buildfarm already used newer compilers #13.
- Thomas committed Victor's macro patch from #6 with an explanatory comment as 3f28bd7337 and announced the push in #14; the original readline-enablement question remained unresolved, and his final message also asked whether documentation should still mention SDK 8.1.