Non-Active links being referred in our source code

Started by vignesh Cover 6 years ago6 messages
#1vignesh C
vignesh21@gmail.com

Hi,

There are few links present in our source files for which the web links are no more active.
Details for the same is given below:

Sl No
Link
Referred File
1
http://h21007.www2.hp.com/portal/download/files/unprot/Itanium/inline_assem_ERS.pdf <http://h21007.www2.hp.com/portal/download/files/unprot/Itanium/inline_assem_ERS.pdf&gt;
generic-acc.h
2
http://h21007.www2.hp.com/portal/download/files/unprot/itanium/spinlocks.pdf <http://h21007.www2.hp.com/portal/download/files/unprot/itanium/spinlocks.pdf&gt;
generic-acc.h
3
http://www.comp.nus.edu.sg/~wuyongzh/my_doc/ntstatus.txt <http://www.comp.nus.edu.sg/~wuyongzh/my_doc/ntstatus.txt&gt;
win32_port.h
4
http://www.microsoft.com/msj/0197/exception/exception.aspx <http://www.microsoft.com/msj/0197/exception/exception.aspx&gt;
win32_port.h
5
http://www.nologs.com/ntstatus.html <http://www.nologs.com/ntstatus.html&gt;
win32_port.h
6
http://www.ross.net/crc/ <http://www.ross.net/crc/&gt;
pg_crc.h
7
http://www.ross.net/crc/download/crc_v3.txt <http://www.ross.net/crc/download/crc_v3.txt&gt;
pg_crc.h
8
http://www.codeproject.com/string/dmetaphone1.asp <http://www.codeproject.com/string/dmetaphone1.asp&gt;
dmetaphone.c
9
http://www.postgresql.org/2009/explain <http://www.postgresql.org/2009/explain&gt;
explain.c
10
http://www.merriampark.com/ld.htm <http://www.merriampark.com/ld.htm&gt;
levenshtein.c
11
http://www.cs.auckland.ac.nz/software/AlgAnim/niemann/s_man.htm <http://www.cs.auckland.ac.nz/software/AlgAnim/niemann/s_man.htm&gt;
rbtree.c

I could not find the equivalent links for the same.
Should we update the links for the same?

Regards,
Vignesh
EnterpriseDB: http://www.enterprisedb.com <http://www.enterprisedb.com/&gt;

#2Michael Paquier
michael@paquier.xyz
In reply to: vignesh C (#1)
Re: Non-Active links being referred in our source code

On Sun, Oct 06, 2019 at 09:06:44AM +0530, vignesh C wrote:

I could not find the equivalent links for the same.
Should we update the links for the same?

If it could be possible to find equivalent links which could update
to, it would be nice.
--
Michael

#3Juan José Santamaría Flecha
juanjo.santamaria@gmail.com
In reply to: Michael Paquier (#2)
1 attachment(s)
Re: Non-Active links being referred in our source code

On Sun, Oct 6, 2019 at 9:41 AM Michael Paquier <michael@paquier.xyz> wrote:

On Sun, Oct 06, 2019 at 09:06:44AM +0530, vignesh C wrote:

I could not find the equivalent links for the same.
Should we update the links for the same?

If it could be possible to find equivalent links which could update
to, it would be nice.

About the broken links in win32_port.h, they are all referring to
ntstatus. As for first case that shows the code groups, there is an up
to date alternative. There is also an alternative for second case that
points to their codes and descriptions. On the other hand, the last
case is quoting a document that is no longer available, I would
suggest to rephrase the comment, thus eliminating the quote.

Please find attached a patch with the proposed alternatives.

Regards,

Juan José Santamaría Flecha

Attachments:

0001-Non-Active-links-in-win32_port.patchapplication/octet-stream; name=0001-Non-Active-links-in-win32_port.patchDownload
diff --git a/src/include/port/win32_port.h b/src/include/port/win32_port.h
index 1cf166a..5c0f9d9 100644
--- a/src/include/port/win32_port.h
+++ b/src/include/port/win32_port.h
@@ -107,7 +107,7 @@
  *	similar to a unix-style signal exit (think SIGSEGV ==
  *	STATUS_ACCESS_VIOLATION).  Return values are broken up into groups:
  *
- *	http://msdn2.microsoft.com/en-gb/library/aa489609.aspx
+ *	https://docs.microsoft.com/en-us/windows-hardware/drivers/kernel/using-ntstatus-values
  *
  *		NT_SUCCESS			0 - 0x3FFFFFFF
  *		NT_INFORMATION		0x40000000 - 0x7FFFFFFF
@@ -121,22 +121,12 @@
  *
  *		Wine (URL used in our error messages) -
  *			http://source.winehq.org/source/include/ntstatus.h
- *		Descriptions - http://www.comp.nus.edu.sg/~wuyongzh/my_doc/ntstatus.txt
- *		MS SDK - http://www.nologs.com/ntstatus.html
+ *		Descriptions -
+ * 			https://docs.microsoft.com/en-us/openspecs/windows_protocols/ms-erref/596a1078-e883-4972-9bbc-49e60bebca55
  *
- *	It seems the exception lists are in both ntstatus.h and winnt.h, but
- *	ntstatus.h has a more comprehensive list, and it only contains
- *	exception values, rather than winnt, which contains lots of other
- *	things:
- *
- *		http://www.microsoft.com/msj/0197/exception/exception.aspx
- *
- *		The ExceptionCode parameter is the number that the operating system
- *		assigned to the exception. You can see a list of various exception codes
- *		in WINNT.H by searching for #defines that start with "STATUS_". For
- *		example, the code for the all-too-familiar STATUS_ACCESS_VIOLATION is
- *		0xC0000005. A more complete set of exception codes can be found in
- *		NTSTATUS.H from the Windows NT DDK.
+ *	The comprehensive exception list is included in ntstatus.h from the Windows
+ *	Driver Kit (WDK). A subset of the list is also included in winnt.h from the
+ *	Windows SDK. The definition of WIN32_NO_STATUS avoids conflict.
  *
  *	Some day we might want to print descriptions for the most common
  *	exceptions, rather than printing an include file name.  We could use
#4Michael Paquier
michael@paquier.xyz
In reply to: Juan José Santamaría Flecha (#3)
Re: Non-Active links being referred in our source code

On Mon, Oct 07, 2019 at 05:11:40PM +0200, Juan José Santamaría Flecha wrote:

About the broken links in win32_port.h, they are all referring to
ntstatus. As for first case that shows the code groups, there is an up
to date alternative. There is also an alternative for second case that
points to their codes and descriptions. On the other hand, the last
case is quoting a document that is no longer available, I would
suggest to rephrase the comment, thus eliminating the quote.

Please find attached a patch with the proposed alternatives.

Thanks Juan for the patch. I have checked your suggestions and it
looks good to me, so committed. Good idea to tell about
WIN32_NO_STATUS. I have noticed one typo on the way.
--
Michael

#5vignesh C
vignesh21@gmail.com
In reply to: Michael Paquier (#4)
1 attachment(s)
Re: Non-Active links being referred in our source code

On Tue, Oct 8, 2019 at 10:35 AM Michael Paquier <michael@paquier.xyz> wrote:

On Mon, Oct 07, 2019 at 05:11:40PM +0200, Juan José Santamaría Flecha wrote:

About the broken links in win32_port.h, they are all referring to
ntstatus. As for first case that shows the code groups, there is an up
to date alternative. There is also an alternative for second case that
points to their codes and descriptions. On the other hand, the last
case is quoting a document that is no longer available, I would
suggest to rephrase the comment, thus eliminating the quote.

Please find attached a patch with the proposed alternatives.

Thanks Juan for the patch. I have checked your suggestions and it
looks good to me, so committed. Good idea to tell about
WIN32_NO_STATUS. I have noticed one typo on the way.

About pg_crc.h, I have made the changes with the correct links.
The patch for the same is attached.

Regards,
Vignesh
EnterpriseDB: http://www.enterprisedb.com

Attachments:

0001-Updated-CRC-links-that-are-not-working.patchapplication/octet-stream; name=0001-Updated-CRC-links-that-are-not-working.patchDownload
From e43d01e9874778bd5f19fff81c8bb3f5b7930746 Mon Sep 17 00:00:00 2001
From: vignesh <vignesh@localhost.localdomain>
Date: Sat, 12 Oct 2019 05:27:52 +0530
Subject: [PATCH] Updated the links that are not working.

Some of the links provided in the files are not working, modified it with the updated links.
---
 src/backend/utils/hash/pg_crc.c | 2 +-
 src/include/utils/pg_crc.h      | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/src/backend/utils/hash/pg_crc.c b/src/backend/utils/hash/pg_crc.c
index 65bf8ff..6ee6ffd 100644
--- a/src/backend/utils/hash/pg_crc.c
+++ b/src/backend/utils/hash/pg_crc.c
@@ -5,7 +5,7 @@
  *
  * See Ross Williams' excellent introduction
  * A PAINLESS GUIDE TO CRC ERROR DETECTION ALGORITHMS, available from
- * http://www.ross.net/crc/download/crc_v3.txt or several other net sites.
+ * http://ross.net/crc/download/crc_v3.txt or several other net sites.
  *
  * Portions Copyright (c) 1996-2019, PostgreSQL Global Development Group
  * Portions Copyright (c) 1994, Regents of the University of California
diff --git a/src/include/utils/pg_crc.h b/src/include/utils/pg_crc.h
index 4d5c99d..766b40b 100644
--- a/src/include/utils/pg_crc.h
+++ b/src/include/utils/pg_crc.h
@@ -5,7 +5,7 @@
  *
  * See Ross Williams' excellent introduction
  * A PAINLESS GUIDE TO CRC ERROR DETECTION ALGORITHMS, available from
- * http://www.ross.net/crc/ or several other net sites.
+ * http://ross.net/crc/index.html or several other net sites.
  *
  * We have three slightly different variants of a 32-bit CRC calculation:
  * CRC-32C (Castagnoli polynomial), CRC-32 (Ethernet polynomial), and a legacy
-- 
1.8.3.1

#6Michael Paquier
michael@paquier.xyz
In reply to: vignesh C (#5)
Re: Non-Active links being referred in our source code

On Mon, Oct 14, 2019 at 09:48:12PM +0530, vignesh C wrote:

About pg_crc.h, I have made the changes with the correct links.
The patch for the same is attached.

Confirmed, so applied. Thanks, Vignesh.
--
Michael