model-writtenrun 9082 - may be wrong, links go to the source messages. Commit-by-commit LLM analysis is in the Commits dialog.
- Peter Eisentraut proposed replacing inconsistent preprocessor conditions to reduce -Wundef warnings and guarding the Datum conversion macros against use without SIZEOF_DATUM in #1.
- Mark Dilger questioned the HSTORE_IS_HSTORE_NEW conversion after finding no definition in the repository or its history, requesting documentation and asking whether obsolete compatibility support could be removed in #3.
- Andrew Gierth explained that HSTORE_IS_HSTORE_NEW belonged to the separately distributed hstore-new extension and argued that unknown surviving historical data justified retaining compatibility code in #4.
- Peter committed #1 as 5d3587d14b with only explanatory comment edits, announced completion in #5, and treated the broader hstore compatibility question as outside the patch's scope in #6.
- After landing, Mark asked whether the historical macro could have been defined as zero in #7; Andrew supplied the original Makefile's -DHSTORE_IS_HSTORE_NEW definition in #8, resolving that concern while the cleanup remained committed and compatibility removal remained outside its scope.