model-writtenrun 8850 - may be wrong, links go to the source messages. Commit-by-commit LLM analysis is in the Commits dialog.
- Steven Winfield reported that filename completion removed SQL COPY's required single quote #1; after Francisco Olarte noted that completion uses the client's filesystem #2, Steven clarified that preserving valid syntax remained necessary and suggested distinguishing COPY from backslash commands #3.
- Tom Lane first proposed preserving user-entered quotes through a force_quote argument #4, but his testing showed that this approach interfered with Readline's directory completion, so he replaced it with quoting/dequoting hooks and a configure-selected libedit fallback #6.
- Alvaro Herrera tested the hook implementation, reported that nonexistent filenames acquired unwanted closing quotes, requested clearer hook references, and questioned the legacy filename-completion declarations #7.
- Robert Haas raised compatibility concerns about substituting Readline for libedit at runtime #8, and Alvaro confirmed that Debian's libedit lacked the quoting hook #10; Tom defended configure-time detection #11 and subsequently verified that Debian's current package simply built against libedit #19.
- After checking ancient libedit headers #15, Tom proposed using rl_-prefixed API names with reversed compatibility macros and removing an obsolete extern declaration #16; he committed this independent cleanup as 5e7bedc5ad and announced it in #18.
- Tom revised the main patch to suppress inappropriate closing quotes, handle directory slashes and dequoting more carefully, and recognize editline headers in configure probes #20; he declined special directory-only completion and backpatching the probe change, citing uncertain benefit and changes to established completion behavior.
- Removal of the Windows configuration header required a rebase into the MSVC configuration generator #21; Alvaro's subsequent testing exposed removal of an existing closing quote #22, which Tom fixed by remembering the input word's last character #23.
- Peter Eisentraut questioned unconditional filename quoting #24, and Tom subsequently found that newer libedit versions could backslash-escape those added quotes into invalid commands, so he limited forced quoting to SQL COPY and already-quoted input and added regression tests #26.
- Peter's testing found that filename completion worked well but double-quoted identifiers containing embedded quotes regressed #27; Tom traced this to Readline stripping the opening double quote before matching #28.
- Tom removed double quote from Readline's recognized quoting characters while retaining single quote #29, deferring broader identifier handling and automatic conversion of double-quoted filenames to a future patch.
- After Peter approved the final revision #30, Tom committed #29 with only minor comment edits as cd69ec66c8; the thread ends with both changes landed and Tom awaiting buildfarm results #31.