Oct 2019

1 commit
Remove one use of IDENT_USERNAME_MAX
30 Oct 2019Peter Eisentrautmaster13beta1REL_19_STABLE13beta1REL_18_STABLE13beta1REL_17_STABLE13beta1REL_16_STABLE13beta1REL_15_STABLE13beta1REL_14_STABLE13beta1REL_13_STABLE13beta1
LLM analysis, 100% suremodified before commitmoderate changesfrom patchset #10 of 2 reviewers saw the final version

The commit retains the IDENT_USERNAME_MAX comment clarification and removes auth_peer()'s fixed-size buffer from #1, but replaces direct use of pw->pw_name with pstrdup(), check_usermap(), and pfree(), and omits the proposed peer-authentication section heading. Peter confirms choosing pstrdup() for consistency with surrounding code #6.

  • Kyotaro Horiguchisaw an earlier versionLLM analysis, 99% sureKyotaro identified the risk of subsequent getpw*() calls overwriting static username storage in the submitted patch, before the committed version added a dynamic copy #2.
  • Tom Lanesaw an earlier versionLLM analysis, 99% sureTom proposed pstrdup() to address the static-storage concern and later required a comment for the alternative direct-pointer approach, but no review of the final implementation appears in the thread #3 #5.

Credits across 1 commit

Author
Peter EisentrautLLM1
Committer
Peter Eisentraut1

N LLM means N of the credits come from LLM analysis, not from commit trailers.