Minor comment fixes for instrumentation.h
Hello,
While going through this file I noticed some inconsistencies in the
comments. Please find attachment for the fix.
--
Regards,
Rafia Sabih
Attachments:
instr_comment_fix.patchtext/x-patch; charset=US-ASCII; name=instr_comment_fix.patchDownload
diff --git a/src/include/executor/instrument.h b/src/include/executor/instrument.h
index 70d8632305..13aaf05453 100644
--- a/src/include/executor/instrument.h
+++ b/src/include/executor/instrument.h
@@ -48,20 +48,20 @@ typedef struct Instrumentation
bool need_bufusage; /* true if we need buffer usage data */
/* Info about current plan cycle: */
bool running; /* true if we've completed first tuple */
- instr_time starttime; /* Start time of current iteration of node */
- instr_time counter; /* Accumulated runtime for this node */
- double firsttuple; /* Time for first tuple of this cycle */
- double tuplecount; /* Tuples emitted so far this cycle */
- BufferUsage bufusage_start; /* Buffer usage at start */
+ instr_time starttime; /* start time of current iteration of node */
+ instr_time counter; /* accumulated runtime for this node */
+ double firsttuple; /* time for first tuple of this cycle */
+ double tuplecount; /* # of tuples emitted so far this cycle */
+ BufferUsage bufusage_start; /* buffer usage at start */
/* Accumulated statistics across all completed cycles: */
- double startup; /* Total startup time (in seconds) */
- double total; /* Total total time (in seconds) */
- double ntuples; /* Total tuples produced */
- double ntuples2; /* Secondary node-specific tuple counter */
+ double startup; /* total startup time (in seconds) */
+ double total; /* total time (in seconds) */
+ double ntuples; /* total tuples produced */
+ double ntuples2; /* secondary node-specific tuple counter */
double nloops; /* # of run cycles for this node */
- double nfiltered1; /* # tuples removed by scanqual or joinqual */
- double nfiltered2; /* # tuples removed by "other" quals */
- BufferUsage bufusage; /* Total buffer usage */
+ double nfiltered1; /* # of tuples removed by scanqual or joinqual */
+ double nfiltered2; /* # of tuples removed by "other" quals */
+ BufferUsage bufusage; /* total buffer usage */
} Instrumentation;
typedef struct WorkerInstrumentation
On Tue, Dec 3, 2019 at 8:36 AM Rafia Sabih <rafia.pghackers@gmail.com> wrote:
While going through this file I noticed some inconsistencies in the
comments. Please find attachment for the fix.
Committed. I think only the duplicated word is a clear error, but the
other changes seem like mild improvements, so pushed the whole thing.
--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
On Thu, 5 Dec 2019 at 14:45, Robert Haas <robertmhaas@gmail.com> wrote:
On Tue, Dec 3, 2019 at 8:36 AM Rafia Sabih <rafia.pghackers@gmail.com> wrote:
While going through this file I noticed some inconsistencies in the
comments. Please find attachment for the fix.Committed. I think only the duplicated word is a clear error, but the
other changes seem like mild improvements, so pushed the whole thing.
True and thank you.
--
Regards,
Rafia Sabih