Dec 2019

1 commit
Offer pnstrdup to frontend code
4 Dec 2019Alvaro Herreramaster13beta1REL_19_STABLE13beta1REL_18_STABLE13beta1REL_17_STABLE13beta1REL_16_STABLE13beta1REL_15_STABLE13beta1REL_14_STABLE13beta1REL_13_STABLE13beta1
LLM analysis, 100% surelanded as postedfrom patchset #60 of 2 reviewers saw the final version

The commit matches all six files and all hunks of #6, including pnstrdup in src/common/fe_memutils.c and the caller conversions. Only index hashes and a hunk offset in src/bin/scripts/common.c differ.

  • Tom Lanesaw an earlier versionLLM analysis, 92% sureTom proposed replacing ecpg_strndup and implementing pnstrdup directly with strnlen, both adopted in the substantial rework; his later bare LGTM does not establish substantive final-version review #2 #4 #6 #7.
  • Andres Freundsaw an earlier versionLLM analysis, 99% sureAndres reviewed the portability and wrapper design and proposed exposing only frontend pnstrdup, which drove the subsequent substantial rework #3 #6.

Credits across 1 commit

Author
Alvaro HerreraLLM1
Committer
Alvaro Herrera1

N LLM means N of the credits come from LLM analysis, not from commit trailers.