Oct - Nov 2020

4 commits
Revert pg_relation_check_pages()
4 Nov 2020Michael Paquiermaster14beta1REL_19_STABLE14beta1REL_18_STABLE14beta1REL_17_STABLE14beta1REL_16_STABLE14beta1REL_15_STABLE14beta1REL_14_STABLE14beta1reverts 3 commits here
LLM analysis, 100% surewritten from the discussion, no matching patch

Removes CheckBuffer(), pg_relation_check_pages(), and their documentation and tests following the locking and alignment objections in #66 and API objections in #78. Michael agreed to revert in #82 and confirmed completion in #84; no revert patch was attached.

Fix incorrect placement of pfree() in pg_relation_check_pages()
29 Oct 2020Michael Paquiermaster14beta1REL_19_STABLE14beta1REL_18_STABLE14beta1REL_17_STABLE14beta1REL_16_STABLE14beta1REL_15_STABLE14beta1REL_14_STABLE14beta1
LLM analysis, 100% surewritten from the discussion, no matching patch

Moves pfree(path) outside check_relation_fork()'s loop in src/backend/utils/adt/pagefuncs.c, exactly the correction Julien identified in #64 after Noriyoshi Shinoda's crash report #63. Michael confirmed the fix in #65; no attached patch contains this correction.

Add pg_relation_check_pages() to check on-disk pages of a relation
28 Oct 2020Michael Paquiermaster14beta1REL_19_STABLE14beta1REL_18_STABLE14beta1REL_17_STABLE14beta1REL_16_STABLE14beta1REL_15_STABLE14beta1REL_14_STABLE14beta1
LLM analysis, 100% surepart of a posted patchsetlight changesfrom patchset #600 of 2 reviewers saw the final version

Commits the SQL wrapper, catalogs, documentation, and tests from #60, leaving its bufmgr.c infrastructure to c780a7a90a. Differences within this subset are comment edits and the catalog-version date; the commit credits Julien Rouhaud and sender Michael Paquier as co-authors.

  • Masahiko Sawadasaw an earlier versiontrailerReviewed permissions, SQL signatures, temporary relations, tests, and API separation through #29, before the substantial redesign in #57.
  • Justin Pryzbysaw an earlier versiontrailerSupplied documentation and comment corrections for #28 in #32, before the SQL interface and verification behavior were substantially reworked.
Add CheckBuffer() to check on-disk pages without shared buffer loading
28 Oct 2020Michael Paquiermaster14beta1REL_19_STABLE14beta1REL_18_STABLE14beta1REL_17_STABLE14beta1REL_16_STABLE14beta1REL_15_STABLE14beta1REL_14_STABLE14beta1
LLM analysis, 100% surepart of a posted patchsetlight changesfrom patchset #600 of 1 reviewer saw the final version

Extracts only src/backend/storage/buffer/bufmgr.c and src/include/storage/bufmgr.h from #60, with comment cleanup and equivalent explicit bitmask comparisons. The commit credits Julien Rouhaud and Michael Paquier, and #62 confirms that the final attachment was split into two commits.

  • Masahiko Sawadasaw an earlier versiontrailerReviewed checksum handling and buffer-state checks and proposed the reusable block-checking API in #22, before the later locking changes and CheckBuffer() rewrite.

Credits across 4 commits

Author
Julien Rouhaud2
Michael Paquier2
Reviewer
Masahiko Sawada2
Justin Pryzby1
Reported by
Shinoda, Noriyoshi (PN Japan FSIP)1
Committer
Michael Paquier4