Mar - Apr 2020

2 commits
Add SQL functions for Unicode normalization
2 Apr 2020Peter Eisentrautmaster13beta1REL_19_STABLE13beta1REL_18_STABLE13beta1REL_17_STABLE13beta1REL_16_STABLE13beta1REL_15_STABLE13beta1REL_14_STABLE13beta1REL_13_STABLE13beta1
LLM analysis, 99% suremodified before commitlight changesfrom patchset #180 of 2 reviewers saw the final version

The commit matches #18, including its binary-search tables, with only the catalog-version bump and four Unicode expected-output lines differing in the supplied files. Peter explicitly confirms choosing this version over John's hash implementation in #22.

  • Daniel Veritesaw an earlier versiontrailerDaniel tested against ICU, reported performance results, and found the supplementary-codepoint over-read #2 #5 #10, before the table representation and supported quick-check paths changed in #18.
  • Andreas Karlssonsaw an earlier versiontrailerAndreas reviewed binary size, conversion costs, and quick-check code style in #7, before the substantive table and lookup changes in #18.
Add support for other normal forms to Unicode normalization API
24 Mar 2020Peter Eisentrautmaster13beta1REL_19_STABLE13beta1REL_18_STABLE13beta1REL_17_STABLE13beta1REL_16_STABLE13beta1REL_15_STABLE13beta1REL_14_STABLE13beta1REL_13_STABLE13beta1
LLM analysis, 100% surepart of a posted patchsetlight changesfrom patchset #62 of 2 reviewers saw the final version

All added and removed lines match the first patch of #6, covering seven files including src/common/unicode_norm.c and src/include/common/unicode_norm_table.h. The SQL patch was excluded, consistent with Peter's announcement in #17.

  • Daniel Veritesaw the final versiontrailerDaniel verified all normalization forms against ICU in #2 and #10 and inspected the API comment in #11; the committed API patch retained the reviewed implementation.
  • Andreas Karlssonsaw the final versiontrailerAndreas reviewed the series and normalization buffer handling in #7, then supported landing its correctness despite performance limitations in #15; the API portion landed unchanged.

Credits across 2 commits

Author
Peter EisentrautLLM2
Reviewer
Andreas Karlsson2
Daniel Verite2
Committer
Peter Eisentraut2

N LLM means N of the credits come from LLM analysis, not from commit trailers.