Jan 2020

2 commits
pgbench: Make more debug messages use common logging API
10 Jan 2020Michael Paquiermaster13beta1REL_19_STABLE13beta1REL_18_STABLE13beta1REL_17_STABLE13beta1REL_16_STABLE13beta1REL_15_STABLE13beta1REL_14_STABLE13beta1REL_13_STABLE13beta1
LLM analysis, 100% surelanded as postedfrom patchset #191 of 1 reviewer saw the final version

The executeMetaCommand() diff exactly matches #19, apart from index-hash abbreviation. In #21, Michael explicitly retained the original combined buffer append, declining the revision in #20; that submission's logging-interface proposal also did not land.

  • Fabien Coelhosaw the final versiontrailerIn #20, Fabien reported that #19 worked for him and supplied an optional buffer-append optimization that the committer declined.
pgbench: Use common logging API
8 Jan 2020Peter Eisentrautmaster13beta1REL_19_STABLE13beta1REL_18_STABLE13beta1REL_17_STABLE13beta1REL_16_STABLE13beta1REL_15_STABLE13beta1REL_14_STABLE13beta1REL_13_STABLE13beta1
LLM analysis, 100% suremodified before commitlight changesfrom patchset #142 of 2 reviewers saw the final version

The commit follows #14, including its syntax-error test, with three small diagnostic edits in src/bin/pgbench/pgbench.c: restoring argv[0] in a shell-launch error, changing 'cannot count' to 'could not count', and preserving the help-hint newline.

  • Michael Paquiersaw the final versiontrailerMichael reviewed diagnostic coverage and formatting in #2, #10, and #12, then inspected the committed version of #14 and challenged its remaining direct logging-level access in #17.
  • Peter Eisentrautsaw the final versiontrailerPeter requested normal logging names in #3, corrected diagnostic ordering and context in #8, and committed the lightly edited #14, announcing completion in #15.

Credits across 2 commits

Author
Fabien COELHO1
Michael Paquier1
Reviewer
Fabien COELHO1
Michael Paquier1
Peter Eisentraut1
Committer
Michael Paquier1
Peter Eisentraut1