Jan 2020

1 commit
Add functions gcd() and lcm() for integer and numeric types.
25 Jan 2020Dean Rasheedmaster13beta1REL_19_STABLE13beta1REL_18_STABLE13beta1REL_17_STABLE13beta1REL_16_STABLE13beta1REL_15_STABLE13beta1REL_14_STABLE13beta1REL_13_STABLE13beta1
LLM analysis, 99% surepart of a posted patchsetmoderate changesfrom patchset #551 of 4 reviewers saw the final version

The commit derives from #55 but deliberately omits the smallint implementations, catalog entries and tests, as proposed in #60 and accepted in #63. It also fixes INT_MIN/+1 handling in int.c and int8.c, reworks numeric.c's gcd_var() around const-pointer inputs and owned temporaries, adjusts numeric scaling, and revises documentation and tests, consistent with the committer's account in #69.

  • Fabien COELHOsaw an earlier versionLLM analysis, 99% sureReviewed tests, signed arithmetic, argument ordering and LCM restrictions in #2, #4, #7, #22, #48 and #54, and received explicit prose review credit in 13661ddd7e, but substantive implementation changes followed.
  • Tom Lanesaw an earlier versionLLM analysis, 93% sureSupported retaining the argument swap in #36 and #38, requested an interrupt check in #51, and explained why smallint overloads were unnecessary in #61, before the final arithmetic and numeric-memory fixes.
  • Alvaro Herrerasaw an earlier versionLLM analysis, 88% sureReviewed the documentation refinement to #55 in #66 and proposed the parenthesized definitions adopted in #68, with coverage limited to documentation before the substantive code adjustments reported in #69.
  • Dean Rasheedsaw the final versioncommittercommitted the patch

Credits across 1 commit

Author
Vik FearingLLM1
Reviewer
Dean Rasheedcommitter1
Committer
Dean Rasheed1

N LLM means N of the credits come from LLM analysis, not from commit trailers.