Mar 2025

1 commit
Increase default maintenance_io_concurrency to 16
18 Mar 2025Melanie Plagemanmaster18beta1REL_19_STABLE18beta1REL_18_STABLE18beta1Also in: BitmapHeapScan streaming read user and prelim refactoring (modified before commit)

Apr 2022

1 commit
pg_walinspect: fix case where flush LSN is in the middle of a record.
30 Apr 2022Jeff Davismaster15beta1REL_19_STABLE15beta1REL_18_STABLE15beta1REL_17_STABLE15beta1REL_16_STABLE15beta1REL_15_STABLE15beta1Also in: pgsql: Add contrib/pg_walinspect. (modified before commit)

Apr 2022

2 commits
Fix recovery_prefetch docs.
8 Apr 2022Thomas Munromaster15beta1REL_19_STABLE15beta1REL_18_STABLE15beta1REL_17_STABLE15beta1REL_16_STABLE15beta1REL_15_STABLE15beta1
LLM analysis, 100% surewritten from the discussion, no matching patch1 of 1 reviewer saw the final version

Corrects the default and grammar errors reported inline by Justin in #164, plus obsolete null-statistics wording that Thomas identified in #165. The attached documentation patch #166 was submitted later and fixes a different issue.

  • Justin Pryzbysaw the final versionLLM analysis, 100% sureIdentified the incorrect recovery_prefetch default and grammatical error in #164, both corrected by this commit.
Prefetch data referenced by the WAL, take II.
7 Apr 2022Thomas Munromaster15beta1REL_19_STABLE15beta1REL_18_STABLE15beta1REL_17_STABLE15beta1REL_16_STABLE15beta1REL_15_STABLE15beta1
LLM analysis, 99% suremodified before commitmoderate changesfrom patchset #1610 of 5 reviewers saw the final version

Matches #161's prefetch implementation, with naming and documentation edits plus substantive changes to statistics reset/computation, publication before waits and recovery completion, and the minimum in-flight limit. Thomas describes the final adjustments and landing in #163.

  • Julien Rouhaudsaw an earlier versiontrailerReviewed the prefetch implementation and tested its debug build in #160 and #162, but moderate statistics and concurrency changes followed before commit.
  • Tomas Vondrasaw an earlier versiontrailerBenchmarked successive implementations and approved the renewed design in #125 and #148, before later filtering, duplicate-prefetch and statistics changes.
  • Alvaro Herrerasaw an earlier versiontrailerReviewed prerequisite APIs and configuration details in #6 and #8, before the single-reader and second-landing redesigns.
  • Andres Freundsaw an earlier versiontrailerReviewed APIs and atomics, diagnosed first-landing failures, and requested test enablement and the try setting in #149 and #153, before subsequent functional revisions.
  • Justin Pryzbysaw an earlier versiontrailerReviewed the first landing's documentation and comments in #87, before the substantial second-landing rework.

Mar 2022

1 commit
Add circular WAL decoding buffer, take II.
18 Mar 2022Thomas Munromaster15beta1REL_19_STABLE15beta1REL_18_STABLE15beta1REL_17_STABLE15beta1REL_16_STABLE15beta1REL_15_STABLE15beta1
LLM analysis, 100% surepart of a posted patchsetlight changesfrom patchset #1551 of 3 reviewers saw the final version

Commits the circular-decoding-buffer component of #155, leaving prefetching for later. Comparison with that component shows comment corrections, formatting and accessor documentation changes rather than algorithm changes.

  • Julien Rouhaudsaw the final versiontrailerReviewed successive circular-buffer revisions and explicitly declared the final component ready in #156, requesting only an assertion placement adjustment.
  • Tomas Vondrasaw an earlier versiontrailerTested the decoding-buffer series and approved #147 in #148, before nonblocking-state handling and WAL_DEBUG support were corrected.
  • Andres Freundsaw an earlier versiontrailerDiagnosed first-landing reader failures and supported the renewed series in #149, before the subsequent nonblocking-state and debug-build fixes.

May 2021

1 commit
Revert recovery prefetching feature.
10 May 2021Thomas Munromaster14beta1REL_19_STABLE14beta1REL_18_STABLE14beta1REL_17_STABLE14beta1REL_16_STABLE14beta1REL_15_STABLE14beta1REL_14_STABLE14beta1reverts 3 commits here
LLM analysis, 100% surewritten from the discussion, no matching patch0 of 4 reviewers saw the final version

Implements the reversion proposed in #96 and #112 and confirmed in #122, removing prefetching, circular decoding and the callback-removal dependency. It is a discussion-driven rollback, not an application of the corrective attachment #109.

  • Tom Lanesaw an earlier versionLLM analysis, 97% sureInvestigated standby corruption and compared successive reversions in #113, while separately corroborating the allocation failure in #118.
  • Andres Freundsaw an earlier versionLLM analysis, 99% sureIdentified continuation-record loops and allocation-before-validation failures in #109 and #110, establishing concrete defects behind the rollback.
  • Stephen Frostsaw an earlier versionLLM analysis, 93% sureExplicitly supported reverting the combined feature in #97 after the recovery failures were reported.
  • Tomas Vondrasaw an earlier versionLLM analysis, 92% sureReported extensive successful x86 and Raspberry Pi regression runs in #116, helping distinguish the platform-specific symptoms during the rollback investigation.

Apr 2021

4 commits
Doc: Review for "Optionally prefetch referenced data in recovery."
9 Apr 2021Thomas Munromaster14beta1REL_19_STABLE14beta1REL_18_STABLE14beta1REL_17_STABLE14beta1REL_16_STABLE14beta1REL_15_STABLE14beta1REL_14_STABLE14beta1
LLM analysis, 100% surewritten from the discussion, no matching patch1 of 1 reviewer saw the final version

Applies Justin's inline patch in #87 correcting documentation, GUC prose and comments, with Thomas rewriting the unclear prefetch comment before confirming the commit in #88. It predates the separate attachment #91.

  • Thomas Munrosaw the final versioncommittercommitted the patch
Optionally prefetch referenced data in recovery.
8 Apr 2021Thomas Munromaster14beta1REL_19_STABLE14beta1REL_18_STABLE14beta1REL_17_STABLE14beta1REL_16_STABLE14beta1REL_15_STABLE14beta1REL_14_STABLE14beta1
LLM analysis, 99% surepart of a posted patchsetmoderate changesfrom patchset #830 of 3 reviewers saw the final version

Combines #83's prefetch and recent-buffer fast-path components in xlogprefetch.c, xlogreader.c and xlogutils.c. The committed version disables the feature by default and adjusts documentation and integration, as announced in #85.

  • Alvaro Herrerasaw an earlier versiontrailerReviewed the original prerequisite APIs in #6 and #8, before the single-reader and callback-removal redesigns.
  • Andres Freundsaw an earlier versiontrailerReviewed prefetch interfaces, statistics and the recent-buffer approach and proposed the simpler counter implementation in #66, before the final reader restructuring.
  • Tomas Vondrasaw an earlier versiontrailerBenchmarked successive versions and reviewed the removal of unflushed-WAL access in #84, before the final default-setting and integration changes.
Add circular WAL decoding buffer.
8 Apr 2021Thomas Munromaster14beta1REL_19_STABLE14beta1REL_18_STABLE14beta1REL_17_STABLE14beta1REL_16_STABLE14beta1REL_15_STABLE14beta1REL_14_STABLE14beta1
LLM analysis, 99% surepart of a posted patchsetmoderate changesfrom patchset #830 of 2 reviewers saw the final version

Extracts the circular-decoding-buffer component of #83. Besides comments and base adjustments, the committed XLogRecHasBlockRef macro adds a max_block_id bounds guard.

  • Tomas Vondrasaw an earlier versionLLM analysis, 95% sureTested circular-reader versions in #53 and #68 and discussed the final restructuring in #84, before the committed bounds-guard change.
  • Jakub Wartaksaw an earlier versionLLM analysis, 96% sureTested the complete circular-reader series, checked replicated data and supplied detailed performance profiles in #64, before the callback-removal rework.
Provide ReadRecentBuffer() to re-pin buffers by ID.
8 Apr 2021Thomas Munromaster14beta1REL_19_STABLE14beta1REL_18_STABLE14beta1REL_17_STABLE14beta1REL_16_STABLE14beta1REL_15_STABLE14beta1REL_14_STABLE14beta1
LLM analysis, 99% surepart of a posted patchsetmoderate changesfrom patchset #830 of 1 reviewer saw the final version

Extracts ReadRecentBuffer() from #83, but rewrites it to validate the buffer tag and BM_VALID before pinning under the appropriate lock. It also adds correct private-reference and local-buffer reference/usage handling.

  • Andres Freundsaw an earlier versiontrailerDiscussed and supported caching and rechecking recent buffer IDs in #72, before the committed lock-before-pin implementation.

Apr 2020

2 commits
Rationalize GetWalRcv{Write,Flush}RecPtr().
8 Apr 2020Thomas Munromaster13beta1REL_19_STABLE13beta1REL_18_STABLE13beta1REL_17_STABLE13beta1REL_16_STABLE13beta1REL_15_STABLE13beta1REL_14_STABLE13beta1REL_13_STABLE13beta1
LLM analysis, 100% surepart of a posted patchsetlight changesfrom patchset #132 of 2 reviewers saw the final version

Matches the WAL-receiver prerequisite in #13 modulo diff indexes and hunk offsets, renaming the flush accessor and adding the new write accessor. Only that component of the four-patch series was committed.

  • Alvaro Herrerasaw the final versiontrailerReviewed receiver naming and declarations in #6 and approved the revised prerequisites in #8, followed only by light changes to this component.
  • Andres Freundsaw the final versiontrailerReviewed the receiver API and accepted reuse of GetWalRcvWriteRecPtr with its changed signature, as Thomas records in #12.
Support PrefetchBuffer() in recovery.
8 Apr 2020Thomas Munromaster13beta1REL_19_STABLE13beta1REL_18_STABLE13beta1REL_17_STABLE13beta1REL_16_STABLE13beta1REL_15_STABLE13beta1REL_14_STABLE13beta1REL_13_STABLE13beta1
LLM analysis, 99% surepart of a posted patchsetlight changesfrom patchset #111 of 2 reviewers saw the final version

Combines #11's shared-buffer prefetch API and outcome-reporting prerequisites across bufmgr.c, localbuf.c and smgr, with comment and formatting cleanup. The main recovery feature and other prerequisites remain outside this commit.

  • Alvaro Herrerasaw an earlier versiontrailerReviewed and approved the earlier prefetch prerequisites in #6 and #8, before the enum-to-structure conversion and revised cache-hit behavior.
  • Andres Freundsaw the final versiontrailerReviewed cache-hit reporting, recent_buffer naming and prefetch behavior in #10, with follow-up review of the revised version recorded in #12.

Credits across 12 commits

Author
Thomas MunroLLM8
Justin PryzbyLLM1
Reviewer
Andres Freund6
Alvaro Herrera4
Tomas Vondra3
Julien Rouhaud2
Jeff Daviscommitter1
Justin Pryzby1
Thomas Munrocommitter1
Tested by
Dmitry Dolgov2
Jakub Wartak2
Sait Talha Nisanci2
Tomas Vondra2
Reported by
Justin Pryzby2
Committer
Thomas Munro10
Jeff Davis1
Melanie Plageman1

N LLM means N of the credits come from LLM analysis, not from commit trailers.