Jan 2020

8 commits
Skip tab-completion tests if envar SKIP_READLINE_TESTS is defined.
9 Jan 2020Tom Lanemaster13beta1REL_19_STABLE13beta1REL_18_STABLE13beta1REL_17_STABLE13beta1REL_16_STABLE13beta1REL_15_STABLE13beta1REL_14_STABLE13beta1REL_13_STABLE13beta1
LLM analysis, 100% surewritten from the discussion, no matching patch

No attachment adds SKIP_READLINE_TESTS; Tom proposes the independent environment variable in #68 and announces its implementation in #69. The commit adds the corresponding skip guard to src/bin/psql/t/010_tab_completion.pl.

Minor style improvements for tab-completion test.
5 Jan 2020Tom Lanemaster13beta1REL_19_STABLE13beta1REL_18_STABLE13beta1REL_17_STABLE13beta1REL_16_STABLE13beta1REL_15_STABLE13beta1REL_14_STABLE13beta1REL_13_STABLE13beta1
LLM analysis, 100% suremodified before commitlight changesfrom patchset #461 of 1 reviewer saw the final version

The commit takes the qr// conversion, banner assertion, and pattern diagnostics from #46, with formatting changes and removal of the accidentally tightened backslash-command regex. Tom explains that portability correction in #47, and Ilmari confirms the accidental edit in #48.

  • Tom Lanesaw the final versioncommittercommitted the patch
Avoid reading ~/.inputrc in tab-completion test, and revert other changes.
5 Jan 2020Tom Lanemaster13beta1REL_19_STABLE13beta1REL_18_STABLE13beta1REL_17_STABLE13beta1REL_16_STABLE13beta1REL_15_STABLE13beta1REL_14_STABLE13beta1REL_13_STABLE13beta1
LLM analysis, 100% suremodified before commitmoderate changesfrom patchset #37

The commit contains the entire rebased patch in #37, originally written by Tom in #33, plus INPUTRC='/dev/null' and its explanatory comment. That additional environment isolation was proposed in #40 and successfully tested in #42.

Don't try to force TERM to a fixed value in tab-completion test.
4 Jan 2020Tom Lanemaster13beta1REL_19_STABLE13beta1REL_18_STABLE13beta1REL_17_STABLE13beta1REL_16_STABLE13beta1REL_15_STABLE13beta1REL_14_STABLE13beta1REL_13_STABLE13beta1
LLM analysis, 88% surepart of a posted patchsetmoderate changesfrom patchset #330 of 1 reviewer saw the final version

The commit takes only the deletion of the forced TERM='xterm' assignment and its comment from #33. It leaves the diagnostic and escape-matching code intact and omits the proposed TERM and LS_COLORS unsetting, providing a temporary rollback while investigation continued.

  • Peter Geoghegansaw an earlier versionLLM analysis, 84% surePeter tested the broader proposal in #33 and reported its continuing failure in #34, before the commit retained only the forced-TERM rollback.
In tab-completion test, print out the value of TERM before changing it.
4 Jan 2020Tom Lanemaster13beta1REL_19_STABLE13beta1REL_18_STABLE13beta1REL_17_STABLE13beta1REL_16_STABLE13beta1REL_15_STABLE13beta1REL_14_STABLE13beta1REL_13_STABLE13beta1
LLM analysis, 100% surewritten from the discussion, no matching patch

The three-line TERM diagnostic in src/bin/psql/t/010_tab_completion.pl has no matching submitted patch. Tom motivates the investigation in #29 and confirms the diagnostic's results in #32.

Make tab-completion tests more robust.
4 Jan 2020Tom Lanemaster13beta1REL_19_STABLE13beta1REL_18_STABLE13beta1REL_17_STABLE13beta1REL_16_STABLE13beta1REL_15_STABLE13beta1REL_14_STABLE13beta1REL_13_STABLE13beta1
LLM analysis, 100% surelanded as postedfrom patchset #261 of 1 reviewer saw the final version

Both hunks match #26: setting TERM='xterm', defining the escape-sequence pattern, and accepting mixed spaces and escapes between completion choices. Peter confirms that version passes in #27, and Tom announces its landing in #28.

  • Peter Geoghegansaw the final versionLLM analysis, 100% surePeter reported that #22 still failed in #23 and verified that the committed revision #26 passed in #27.
Further fixes for tab-completion TAP tests.
3 Jan 2020Tom Lanemaster13beta1REL_19_STABLE13beta1REL_18_STABLE13beta1REL_17_STABLE13beta1REL_16_STABLE13beta1REL_15_STABLE13beta1REL_14_STABLE13beta1REL_13_STABLE13beta1
LLM analysis, 100% suremodified before commitlight changesfrom patchset #81 of 1 reviewer saw the final version

The commit includes every diagnostics change from #8 unchanged and adds a relaxed backslash-command assertion that avoids depending on exact backspacing behavior. Tom confirms that he pushed the attachment together with this additional fix in #11.

  • Tom Lanesaw the final versioncommittercommitted the patch
Add an ugly workaround for a bug in some recent libedit versions.
3 Jan 2020Tom Lanemaster13beta1REL_19_STABLE13beta1REL_18_STABLE13beta1REL_17_STABLE13beta1REL_16_STABLE13beta1REL_15_STABLE13beta1REL_14_STABLE13beta1REL_13_STABLE13beta1
LLM analysis, 100% surewritten from the discussion, no matching patch

No attachment changes src/bin/psql/tab-complete.c. The commit implements Tom's proposal in #4 to recover completion text from rl_line_buffer rather than libedit's prematurely de-escaped argument, following Christoph's failure report in #2.

Credits across 8 commits

Author
Tom LaneLLM3
Dagfinn Ilmari MannsåkerLLM2
Reviewer
Tom Lanecommitter2
Committer
Tom Lane8

N LLM means N of the credits come from LLM analysis, not from commit trailers.