Code cleanup for build_regexp_split_result

Started by Japin Liabout 6 years ago2 messageshackers
Jump to latest
#1Japin Li
japinli@hotmail.com

Hi hackers,

I find the build_regexp_split_result() has redundant codes, we can move it to before the condition check, can we?

Best regards.

Japin Li

Attachments:

0001-Code-cleanup-for-build_regexp_split_result.patchapplication/octet-stream; name=0001-Code-cleanup-for-build_regexp_split_result.patchDownload+4-7
#2Tom Lane
tgl@sss.pgh.pa.us
In reply to: Japin Li (#1)
Re: Code cleanup for build_regexp_split_result

Li Japin <japinli@hotmail.com> writes:

I find the build_regexp_split_result() has redundant codes, we can move it to before the condition check, can we?

Hm, yeah, that looks a bit strange. It was less strange before
c8ea87e4bd950572cba4575e9a62284cebf85ac5, I think.

Pushed with some additional simplification to get rid of the
rather ugly (IMO) PG_USED_FOR_ASSERTS_ONLY variable.

regards, tom lane