Mar 2020

2 commits
Report NULL as total backup size if it's not estimated.
24 Mar 2020Fujii Masaomaster13beta1REL_19_STABLE13beta1REL_18_STABLE13beta1REL_17_STABLE13beta1REL_16_STABLE13beta1REL_15_STABLE13beta1REL_14_STABLE13beta1REL_13_STABLE13beta1
LLM analysis, 100% suremodified before commitlight changesfrom patchset #563 of 3 reviewers saw the final version

The commit preserves all implementation, documentation, and regression changes from #56, including the -1-to-NULL conversion in src/backend/catalog/system_views.sql. Its only additional change is a catalog-version bump in src/include/catalog/catversion.h.

  • Amit Langotesaw the final versiontrailerDiscussed sentinel semantics in #59 and explicitly accepted the view-local conversion after inspecting the patch in #64.
  • Magnus Hagandersaw the final versiontrailerQuestioned the SQL-level -1-to-NULL conversion in #57 and proposed considering support in pg_stat_get_progress_info().
  • Alvaro Herrerasaw the final versiontrailerConsidered alternative sentinel values in #60, then inspected the code and endorsed interpreting -1 in the view in #62.
Make pg_basebackup ask the server to estimate the total backup size, by default.
19 Mar 2020Fujii Masaomaster13beta1REL_19_STABLE13beta1REL_18_STABLE13beta1REL_17_STABLE13beta1REL_16_STABLE13beta1REL_15_STABLE13beta1REL_14_STABLE13beta1REL_13_STABLE13beta1
LLM analysis, 100% surelanded as postedfrom patchset #541 of 2 reviewers saw the final version

Matches #54 across src/bin/pg_basebackup/pg_basebackup.c and both documentation files; differences are only base hashes and documentation hunk offsets. Fujii announced the push in #65.

  • Magnus Hagandersaw the final versiontrailerRequested removal of the server-version dependency and documentation revisions in #51, then checked the resulting changes in #55.
  • Amit Langotesaw an earlier versiontrailerReviewed the initial client patch and requested documentation edits in #49, before removal of the server-version gate changed its behavior.

Mar 2020

1 commit
Report progress of streaming base backup.
3 Mar 2020Fujii Masaomaster13beta1REL_19_STABLE13beta1REL_18_STABLE13beta1REL_17_STABLE13beta1REL_16_STABLE13beta1REL_15_STABLE13beta1REL_14_STABLE13beta1REL_13_STABLE13beta1
LLM analysis, 100% suremodified before commitlight changesfrom patchset #292 of 3 reviewers saw the final version

Implements #29 with formatting and comment wrapping in src/backend/replication/basebackup.c, macro alignment in src/include/commands/progress.h, and a catalog-version bump. No progress-reporting logic changed.

  • Kyotaro Horiguchisaw the final versiontrailerIdentified the premature streaming-phase transition in #2, then reported the final patch working as designed and requested macro alignment in #31.
  • Amit Langotesaw an earlier versiontrailerReviewed naming, phase granularity, and documentation through #25, but the subsequent atomic multi-parameter update change in #28 was not reviewed by him in this thread.
  • Sergei Kornilovsaw the final versiontrailerReviewed the final submission and identified inconsistent macro alignment in src/include/commands/progress.h in #30.

Credits across 3 commits

Author
Fujii Masao3
Reviewer
Amit Langote3
Magnus Hagander2
Alvaro Herrera1
Kyotaro Horiguchi1
Sergei Kornilov1
Committer
Fujii Masao3