May 2020

1 commit
Change the display of WAL usage statistics in Explain.
5 May 2020Amit Kapilamaster13beta1REL_19_STABLE13beta1REL_18_STABLE13beta1REL_17_STABLE13beta1REL_16_STABLE13beta1REL_15_STABLE13beta1REL_14_STABLE13beta1REL_13_STABLE13beta1
LLM analysis, 100% surelanded as postedfrom patchset #1693 of 3 reviewers saw the final version

The eleven-file diff matches #169, including single-space EXPLAIN fields, capitalized non-text labels, and the FPI rename. Amit forwarded and polished Julien's work from #167; the commit credits both as authors.

  • Justin Pryzbysaw the final versiontrailerJustin requested acronym documentation and capitalization in #149 and advocated FPI terminology in #153, after which only cosmetic changes followed.
  • Kyotaro Horiguchisaw the final versiontrailerKyotaro checked documentation and identified the FPW/image terminology mismatch in #151 and reviewed the subsequent revision in #158.
  • Amit Kapilasaw the final versiontrailerAmit reviewed formatting and naming, prepared the final capitalization and pgindent changes in #169, and committed the result.

Apr 2020

7 commits
Cosmetic fixups for WAL usage work.
13 Apr 2020Amit Kapilamaster13beta1REL_19_STABLE13beta1REL_18_STABLE13beta1REL_17_STABLE13beta1REL_16_STABLE13beta1REL_15_STABLE13beta1REL_14_STABLE13beta1REL_13_STABLE13beta1
LLM analysis, 100% surelanded as postedfrom patchset #1411 of 1 reviewer saw the final version

The nine-file cosmetic diff matches #141 exactly. Amit forwarded Julien's consolidated patch from #137, which also incorporated Justin Pryzby's documentation work; the commit credits Julien and Justin.

  • Amit Kapilasaw the final versiontrailerAmit corrected terminology and count-versus-number wording in #141 and committed that version.
Allow parallel create index to accumulate buffer usage stats.
9 Apr 2020Amit Kapilamaster13beta1REL_19_STABLE13beta1REL_18_STABLE13beta1REL_17_STABLE13beta1REL_16_STABLE13beta1REL_15_STABLE13beta1REL_14_STABLE13beta1REL_13_STABLE13beta1+2 more
LLM analysis, 100% surelanded as postedfrom patchset #1201 of 3 reviewers saw the final version

The nbtsort.c and instrument.c changes match #120 exactly. The later attachments in #133 are adaptations for stable branches, not a newer development-branch source.

  • Dilip Kumarsaw an earlier versiontrailerDilip tested parallel-index buffer totals in #66 and #76, before the patch was adapted to the landed WAL APIs and shared instrumentation helpers.
  • Julien Rouhaudsaw an earlier versiontrailerJulien tested and reviewed the original index-buffer fix in #44, before launched-worker corrections and integration with the later WAL infrastructure.
  • Amit Kapilasaw the final versiontrailerAmit reviewed worker accounting, investigated catalog-access differences, requested backbranch verification in #131, and committed the final patch.
Allow autovacuum to log WAL usage statistics.
6 Apr 2020Amit Kapilamaster13beta1REL_19_STABLE13beta1REL_18_STABLE13beta1REL_17_STABLE13beta1REL_16_STABLE13beta1REL_15_STABLE13beta1REL_14_STABLE13beta1REL_13_STABLE13beta1
LLM analysis, 100% surelanded as postedfrom patchset #1112 of 2 reviewers saw the final version

Matches the autovacuum-only patch in #111; reconstruction against its base shows only whitespace differences, including removal of an unrelated blank line in lazy_scan_heap.

  • Dilip Kumarsaw the final versiontrailerDilip explicitly reviewed the vacuum component in #79, and its surviving autovacuum portion subsequently received only light changes.
  • Amit Kapilasaw the final versiontrailerAmit reviewed the logging code in #104, requested deferral of manual VACUUM VERBOSE reporting in #109, and committed the reduced patch.
Add the option to report WAL usage in EXPLAIN and auto_explain.
6 Apr 2020Amit Kapilamaster13beta1REL_19_STABLE13beta1REL_18_STABLE13beta1REL_17_STABLE13beta1REL_16_STABLE13beta1REL_15_STABLE13beta1REL_14_STABLE13beta1REL_13_STABLE13beta1
LLM analysis, 99% surepart of a posted patchsetlight changesfrom patchset #972 of 2 reviewers saw the final version

Lands the EXPLAIN/auto_explain component of the four-part series in #97, with unchanged functionality after rebase and diff-context adjustments. That component was authored by Julien and forwarded by Amit.

  • Dilip Kumarsaw the final versiontrailerDilip explicitly reviewed EXPLAIN labels in #71 and caught a misplaced EXPLAIN correction in #79, with only light presentation changes afterward.
  • Amit Kapilasaw the final versiontrailerAmit reviewed the interface, prepared #97, considered planning-phase reporting in #98, and committed the execution-phase implementation.
Allow pg_stat_statements to track WAL usage statistics.
5 Apr 2020Amit Kapilamaster13beta1REL_19_STABLE13beta1REL_18_STABLE13beta1REL_17_STABLE13beta1REL_16_STABLE13beta1REL_15_STABLE13beta1REL_14_STABLE13beta1REL_13_STABLE13beta1
LLM analysis, 100% surepart of a posted patchsetlight changesfrom patchset #973 of 4 reviewers saw the final version

Lands only the pg_stat_statements component of #97; reconstructing its five changed files produces the committed contents exactly. Amit forwarded work credited to Kirill Bychik and Julien Rouhaud.

  • Julien Rouhaudsaw the final versiontrailerJulien reviewed Kirill's patches in #6 and #13, then developed and tested the final implementation through #85.
  • Fujii Masaosaw an earlier versiontrailerFujii reviewed names, SQL declarations, tests, and upgrade handling in #24, before unsigned-byte conversion and planning-phase accounting were added.
  • Dilip Kumarsaw the final versiontrailerDilip explicitly reviewed pg_stat_statements in #79 and tested its later WAL results in #86, #92, and #95.
  • Amit Kapilasaw the final versiontrailerAmit reviewed regression scope, numeric conversion, planning integration, and column ordering before preparing #97 and committing its pg_stat_statements component.
Add infrastructure to track WAL usage.
4 Apr 2020Amit Kapilamaster13beta1REL_19_STABLE13beta1REL_18_STABLE13beta1REL_17_STABLE13beta1REL_16_STABLE13beta1REL_15_STABLE13beta1REL_14_STABLE13beta1REL_13_STABLE13beta1
LLM analysis, 100% surepart of a posted patchsetlight changesfrom patchset #972 of 3 reviewers saw the final version

The commit's changed lines exactly match the infrastructure component of #97, leaving its three consumers for separate commits. Amit forwarded the instrumentation work credited to Kirill Bychik and Julien Rouhaud.

  • Dilip Kumarsaw the final versiontrailerDilip reviewed counter naming and parallel instrumentation, then validated the later implementation by tracing apparent WAL discrepancies to actual catalog activity in #92 and #95.
  • Fujii Masaosaw an earlier versiontrailerFujii identified retry overcounting, the incorrect DSM pointer, and counter-type issues in #23, before counting logic and parallel-maintenance coverage were substantially revised.
  • Amit Kapilasaw the final versiontrailerAmit reviewed FPI semantics and parallel maintenance, polished #97, and announced the infrastructure commit in #98.
Allow parallel vacuum to accumulate buffer usage.
2 Apr 2020Amit Kapilamaster13beta1REL_19_STABLE13beta1REL_18_STABLE13beta1REL_17_STABLE13beta1REL_16_STABLE13beta1REL_15_STABLE13beta1REL_14_STABLE13beta1REL_13_STABLE13beta1
LLM analysis, 100% surepart of a posted patchsetlight changesfrom patchset #723 of 3 reviewers saw the final version

Exactly matches the parallel-vacuum buffer component most recently bundled in #72, also previously posted standalone in #65. Julien forwarded Masahiko Sawada's fix alongside the WAL series.

  • Dilip Kumarsaw the final versiontrailerDilip found stale-statistics double counting in #58, tested the corrected patch with multi-pass vacuum in #64, and subsequently approved the cosmetic revision.
  • Amit Kapilasaw the final versiontrailerAmit corrected launched-worker handling, suggested the no-worker guard, tested and polished #65, and committed that implementation.
  • Julien Rouhaudsaw the final versiontrailerJulien tested the original vacuum fix in #44, integrated the corrected version in #67, and tested combined parallel accounting in #72.

Credits across 8 commits

Author
Julien Rouhaud6
Kirill Bychik2
Masahiko Sawada2
Amit Kapila1
Justin Pryzby1
Reviewer
Amit Kapila8
Dilip Kumar6
Julien Rouhaud3
Fujii Masao2
Justin Pryzby1
Kyotaro Horiguchi1
Reported by
Julien Rouhaud2
Euler Taveira1
Justin Pryzby1
Committer
Amit Kapila8