Mar 2020

3 commits
Rearrange validity checks for plpgsql "simple" expressions.
27 Mar 2020Tom Lanemaster13beta1REL_19_STABLE13beta1REL_18_STABLE13beta1REL_17_STABLE13beta1REL_16_STABLE13beta1REL_15_STABLE13beta1REL_14_STABLE13beta1REL_13_STABLE13beta1
LLM analysis, 100% surewritten from the discussion, no matching patch

Implements the buildfarm-triggered correction described in #41, with no matching attached patch: CachedPlanAllowsSimpleValidityCheck() accepts a valid derived plan despite an invalid plansource and acquires its reference directly, while subsequent rechecks still require plansource validity.

Improve performance of "simple expressions" in PL/pgSQL.
26 Mar 2020Tom Lanemaster13beta1REL_19_STABLE13beta1REL_18_STABLE13beta1REL_17_STABLE13beta1REL_16_STABLE13beta1REL_15_STABLE13beta1REL_14_STABLE13beta1REL_13_STABLE13beta1
LLM analysis, 100% surepart of a posted patchsetlight changesfrom patchset #371 of 2 reviewers saw the final version

Commits the tests, fast plancache validation, resource-owner management, and search-path optimization from #37, after the parallel-worker fix was extracted into 86e5badd22. Reconstructing the posted series against repository blobs shows that the combined committed result differs only in comments in pl_exec.c and pl_handler.c; the other ten files match exactly.

  • Pavel Stehulesaw an earlier versionLLM analysis, 99% sureProposed retaining SQL-function planning, benchmarked successive implementations, and confirmed regression and plpgsql_check results in #24 and #25, before the resource-owner logic changed in #37.
  • Andres Freundsaw the final versionLLM analysis, 100% sureReviewed resource-owner lifetimes, validity checks, and search-path handling in #28 through #32, then reviewed #37 in #38; the commit also explicitly credits his review.
Ensure that plpgsql cleans up cleanly during parallel-worker exit.
26 Mar 2020Tom Lanemaster13beta1REL_19_STABLE13beta1REL_18_STABLE13beta1REL_17_STABLE13beta1REL_16_STABLE13beta1REL_15_STABLE13beta1REL_14_STABLE13beta1REL_13_STABLE13beta1+5 more
LLM analysis, 100% surepart of a posted patchsetlight changesfrom patchset #371 of 1 reviewer saw the final version

Extracts #37's XACT_EVENT_PARALLEL_COMMIT and XACT_EVENT_PARALLEL_ABORT handling in plpgsql_xact_cb(), together with expanded DO-block lifecycle comments in pl_exec.c and pl_handler.c. The performance changes remain for 8f59f6b9c0, allowing this cleanup fix to be backpatched separately as explained in #40.

  • Andres Freundsaw the final versionLLM analysis, 94% sureExamined the parallel-worker cleanup and JIT consequences of #37 and requested a DO-resource comment cross-reference in #38, which Tom accepted in #39.

Credits across 3 commits

Author
Tom LaneLLM2
Committer
Tom Lane3

N LLM means N of the credits come from LLM analysis, not from commit trailers.