False failure during repeated windows build.
Hello.
I found it quite annoying that it stops with complaining as "unused
defines" during repeated execution of build.pl. The subroutine
GenerateConfigHeader prepares %defines_copy before checking the
newness of $config_header and even if it decides not to generate new
one, the following code makes sure if the %defines_copy is empty, then
of course it fails with the message.
The attached fixes that.
regards.
--
Kyotaro Horiguchi
NTT Open Source Software Center
Attachments:
0001-Fix-behavior-for-repeated-build-on-Windows.patchtext/x-patch; charset=us-asciiDownload+7-6
On Tue, Feb 18, 2020 at 8:06 AM Kyotaro Horiguchi <horikyota.ntt@gmail.com>
wrote:
The attached fixes that.
After commit 9573384 this patch no longer applies, but with a trivial
rebase it fixes the issue.
Regards,
Juan José Santamaría Flecha
At Fri, 21 Feb 2020 14:02:40 +0100, Juan José Santamaría Flecha <juanjo.santamaria@gmail.com> wrote in
After commit 9573384 this patch no longer applies, but with a trivial
rebase it fixes the issue.
Thanks! This is the rebased version. I'll register this to the next CF.
regards.
--
Kyotaro Horiguchi
NTT Open Source Software Center
Attachments:
v2-0001-Fix-behavior-for-repeated-build-on-Windows.patchtext/x-patch; charset=us-asciiDownload+7-6
On Tue, Feb 25, 2020 at 10:14:10AM +0900, Kyotaro Horiguchi wrote:
At Fri, 21 Feb 2020 14:02:40 +0100, Juan José Santamaría Flecha <juanjo.santamaria@gmail.com> wrote in
After commit 9573384 this patch no longer applies, but with a trivial
rebase it fixes the issue.Thanks! This is the rebased version. I'll register this to the next CF.
That's annoying, and you are right. So, committed.
--
Michael
At Tue, 25 Feb 2020 14:02:04 +0900, Michael Paquier <michael@paquier.xyz> wrote in
On Tue, Feb 25, 2020 at 10:14:10AM +0900, Kyotaro Horiguchi wrote:
At Fri, 21 Feb 2020 14:02:40 +0100, Juan José Santamaría Flecha <juanjo.santamaria@gmail.com> wrote in
After commit 9573384 this patch no longer applies, but with a trivial
rebase it fixes the issue.Thanks! This is the rebased version. I'll register this to the next CF.
That's annoying, and you are right. So, committed.
Thank you for committing.
regards.
--
Kyotaro Horiguchi
NTT Open Source Software Center