Minor improvement to partition_bounds_copy()
partition_bounds_copy() sets the hash_part and natts variable in each
iteration of a loop to copy the datums in the datums array, which
would not be efficient. Attached is small patch for avoiding that.
Best regards,
Etsuro Fujita
Attachments:
partition_bounds_copy.patchapplication/octet-stream; name=partition_bounds_copy.patchDownload+9-7
Fujita-san,
On Thu, Feb 20, 2020 at 8:36 PM Etsuro Fujita <etsuro.fujita@gmail.com> wrote:
partition_bounds_copy() sets the hash_part and natts variable in each
iteration of a loop to copy the datums in the datums array, which
would not be efficient. Attached is small patch for avoiding that.
That looks good to me.
Thanks,
Amit
On Thu, Feb 20, 2020 at 09:38:26PM +0900, Amit Langote wrote:
Fujita-san,
On Thu, Feb 20, 2020 at 8:36 PM Etsuro Fujita <etsuro.fujita@gmail.com> wrote:
partition_bounds_copy() sets the hash_part and natts variable in each
iteration of a loop to copy the datums in the datums array, which
would not be efficient. Attached is small patch for avoiding that.That looks good to me.
Looks good to me too!
On Thu, Feb 20, 2020 at 10:52 PM Julien Rouhaud <rjuju123@gmail.com> wrote:
On Thu, Feb 20, 2020 at 09:38:26PM +0900, Amit Langote wrote:
On Thu, Feb 20, 2020 at 8:36 PM Etsuro Fujita <etsuro.fujita@gmail.com> wrote:
partition_bounds_copy() sets the hash_part and natts variable in each
iteration of a loop to copy the datums in the datums array, which
would not be efficient. Attached is small patch for avoiding that.That looks good to me.
Looks good to me too!
Pushed. Thanks, Amit and Julien!
Best regards,
Etsuro Fujita